Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1531.
Logs errors in a Redis connection to an additional
sinkbuffer, and returns them wheneverDEBUG ERRORS
is invoked. Thesinkbuffer is stored withinRedisReplyBuilder
, and is given in the constructor. It is individual per ReplyBuilder, hence per connection.very MVP for now, no need to review unless you see something critical :)
StringSink
with aRingBufferSink
RingBuffer<std::string>