chore: pull helio and adjust mimalloc for 32MiB segments #3174
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kostasrim
commented
Jun 13, 2024
•
kostasrim
commented
- pull helio
- use mimalloc 32MiB segments
- adjust SegmentAllocator
kostasrim
commented
Jun 13, 2024
src/core/segment_allocator.cc
Outdated
| static_assert(kSegLogSpan == kSegmentShift); | ||
| static_assert((~kSegmentAlignMask) == (MI_SEGMENT_SIZE - 1)); | ||
| // static_assert((~kSegmentAlignMask) == (MI_SEGMENT_SIZE - 1)); |
There was a problem hiding this comment.
99% Sure this was a mistake. When this was introduced it would not pass the assertion on the previous versions.
Also mimalloc uses 32MiB segments but we fetch 4MiB. We can bump this up to 8MiB or 32MiB to give 1-1 mapping.
I am not very familiar with SmallString which uses this extensively so I will update on this.
kostasrim
commented
Jun 30, 2024
| @@ -17,16 +17,19 @@ namespace dfly { | |||
|
|
|||
| /** | |||
| * @brief Tightly coupled with mi_malloc 2.x implementation. | |||
| * Fetches 4MiB segment pointers from the allocated pointers. | |||
| * Fetches 32MiB segment pointers from the allocated pointers. | |||
There was a problem hiding this comment.
It doesn't really make a difference if we use 8MiB here as it was before we switched to mimalloc version that used 4MiBSegments because either way SmallString will hold a 4 bytes pointer so it won't affect its memory footprint which is the goal of this anyway
|
passes locally we need to merge: romange/helio#283 and pull this here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.