fix(sanitizers): failing json test #3176

kostasrim · 2024-06-14T08:53:27Z

fix sanitizers for json MGET tests

kostasrim · 2024-06-14T08:53:53Z

actions https://github.com/dragonflydb/dragonfly/actions/runs/9513408447

src/core/json/lexer_impl.cc

romange · 2024-06-14T14:51:37Z

src/server/json_family_test.cc

@@ -952,8 +952,10 @@ TEST_F(JsonFamilyTest, MGet) {
  resp = Run({"JSON.SET", "json2", ".", json[1]});
  ASSERT_THAT(resp, "OK");

+#ifndef SANITIZERS


is it a good solution? Do you know why it failed?

I am fairly certain that it's a false positive. I thought it was ADL and a funky conversion somewhere but I was wrong on that. I will spent a little bit time on this and ping back just to be on the safe side

It is a false positive, I stepped it through in debug build and everything is fine in the flow. I switched off the check

romange · 2024-06-14T15:01:09Z

I suggest to disable this particular feature altogether:
https://github.com/google/sanitizers/wiki/AddressSanitizerUseAfterReturn
i.e. ASAN_OPTIONS=detect_stack_use_after_return=0

kostasrim · 2024-06-14T16:24:05Z

I suggest to disable this particular feature altogether: https://github.com/google/sanitizers/wiki/AddressSanitizerUseAfterReturn i.e. ASAN_OPTIONS=detect_stack_use_after_return=0

I understand that this is flaky because of the false positives but it could also be useful sometimes and I don't mind spending a few minutes to investigate when this happens. I don't have a strong opinion on this so I am happy to disable this.

romange · 2024-06-14T16:44:27Z

I prefer disabling this specific check since we know that asan do not work well with fibers - the noise is not worth it to micro optimize those tests

romange · 2024-06-24T10:01:40Z

LGTM
When I have time I will try to overlay the info in this thread:
google/sanitizers#1760

and see if it can fix the problem

…nfly ( v1.19.2 → v1.20.0 ) (#3956) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.dragonflydb.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly) | minor | `v1.19.2` -> `v1.20.0` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly (docker.dragonflydb.io/dragonflydb/dragonfly)</summary> ### [`v1.20.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.0) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.19.2...v1.20.0) ##### Dragonfly v1.20.0 Some prominent changes include: - Improvements around client side caching ([#3136](https://togithub.com/dragonflydb/dragonfly/issues/3136) [#3158](https://togithub.com/dragonflydb/dragonfly/issues/3158)) Specifically, rueidis is now supported ([#2454](https://togithub.com/dragonflydb/dragonfly/issues/2454)) - Improvements around search and vector search APIs, FT.ALTER is now supported ([#3144](https://togithub.com/dragonflydb/dragonfly/issues/3144), [#3148](https://togithub.com/dragonflydb/dragonfly/issues/3148), [#3178](https://togithub.com/dragonflydb/dragonfly/issues/3178), [#3186](https://togithub.com/dragonflydb/dragonfly/issues/3186)) - JSON.MSET is added ([#3167](https://togithub.com/dragonflydb/dragonfly/issues/3167)) - Expiry notifications are now supported ([#3154](https://togithub.com/dragonflydb/dragonfly/issues/3154)) ##### What's Changed - test(cluster_mgr): Add tests for cluster_mgr.py by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3129 - chore: get rid of kv_args and replace it with slices to full_args by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3101 - fix: Fix live-lock in connection test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3135 - chore: call breaker_cb\_ on shutdown by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3128 - chore: Add option to disable aws dependency by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3077 - feat(cluster): Add important logs by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3138 - chore: a small cleanup by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3140 - test: skip test_cluster_migration_cancel, it is broken by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3146 - chore: update helio by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3150 - fix: fix bug in cluster/slot_set by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3143 - chore: recommit client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3136 - feat(search): Tag field options (separator, case sensitivity) by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3144 - feat(search): basic FT.ALTER by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3148 - chore: Introduce pipeline back-pressure by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3152 - fix: lua and client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3163 - feat: client tracking optout by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3158 - feat: add noloop subcommand in client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3164 - fix(ci): docker not using iouring by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3169 - fix(ci): add missing docker option on reg tests workflow by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3172 - fix: acl compatibility by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3147 - chore: Streamer is rewritten with async interface by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3108 - feat(json): MSET by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3167 - fix(cluster): Wait for flow creation before cancelling it by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3159 - chore: improve ft.create for vector search by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3178 - feat: add incoming migration error processing by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3175 - chore: add parsing support for the rest of VECTOR parameters by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3179 - fix(cluster): Wait before all access to slot migrations by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3180 - fix(server): fix bug in replication on cached mode by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3156 - chore: small acl compat changes by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3177 - chore: allow calling Context::ReportError from I/O dispatch fiber by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3182 - chore: add a lexer test covering KNN query by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3185 - chore(search): Add \__vector_score alias by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3186 - chore: Refactor string span management by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3165 - chore(ci): run replication tests on arm by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3168 - chore(search): improve parser error reporting by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3184 - fix(reply_builder): remove virtual modifier in SendError(ErrorReply) method by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3191 - fix(cluster): Support `FLUSHALL` while slot migration is in progress by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3173 - fix: fix RegisterOnChange methods for journal and db_slice by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3171 - fix(generic_family): fix RenameGeneric command for non-string data types by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3181 - fix(server): Rename confusing flag `replica_reconnect_on_master_restart` by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3193 - fix(unit tests): fix generic family info test by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3187 - test: improve cluster_fuzzy_migration test by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3197 - chore(core): Remove DfImpl inside ScoredMap by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3199 - chore(tiering): Remove IoMgr by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3198 - test(cluster): Make sure migration maintains TTL by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3188 - feat(cluster): Support `STICK` bit in slot migration by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3200 - chore: Re-enable previously flaky test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3196 - feat(acl): add support of multiple passwords by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3189 - chore(tiering): More advanced tiering tests by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3201 - chore: add replica-priority flag by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3204 - chore: fix tiering regtest test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3208 - feat(generic_family): Assemble RESTORE and STICK commands into one commmand during replication of the RENAME command by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3209 - core(search): Add EF_RUNTIME parameter by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3206 - fix(sanitizers): failing json test by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3176 - feat(server): expiry notifications by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3154 - fix: replicaof_reject_on_load flake by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3203 - fix(cluster): Don't miss keys when migrating slots by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3218 - fix(tiering): Fix pending leak during immediate stash error by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3219 - chore: provide basic logging to catch possible command errors by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3213 - chore: disable tiering test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3236 - fix(transaction): Don't transactionalize empty EVAL inside EXEC by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3231 - fix: fix deadlock in DFLYCLUSTER CONFIG command and outgoing migration finaliztion by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3239 - chore(tiered): minor fixes + expose buffer allocation type stats by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3234 - fix(pytest): timed ticker for simpler conditions by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3242 - fix(server): Fix SCAN deadlock by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3235 - chore: introduce back-pressure to tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3243 - chore: improve dfly_bench by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3244 - chore(tiering): External alloc free page chaining by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3237 - fix: total_stash_overflows statistic by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3248 - chore: update action versions by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3250 - chore(lua): Return which undeclared key was accessed by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3245 - chore: replace session wide fixtures with scope by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3251 - chore: pull helio and adjust mimalloc for 32MiB segments by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3174 - chore: add more logs around the duplicate value case in small_bins by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3254 - fix: fix move error during migration finalization by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3253 - chore: upload all the logs from /tmp by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3263 - fix(tiering): Throttle snapshot load by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3249 - chore: initiate grow preemptively by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3267 - chore(monitoring): add more dashboards + memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3268 - fix(json_family): fix JSON.GET commmand for JSON legacy mode by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3261 - chore: dfly_bench can send traffic to memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3271 - chore: print effective QPS of the server. by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3274 - chore: debugging fixes by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3275 - chore: more debug checks around tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3277 - chore(license): Fix typo in LICENSE.md text by [@softmoth](https://togithub.com/softmoth) in [dragonflydb/dragonfly#3283 - fix(test): Verify that save has not finished by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3278 - Create scorecard.yml by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3270 - chore: Disable cluster_mgr_test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3279 - fix: Increase key count to make test more robust by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3286 - fix: properly clean tiered state upon flash by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3281 - fix(bug): crash on takeover and info replication by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3282 ##### New Contributors - [@softmoth](https://togithub.com/softmoth) made their first contribution in [dragonflydb/dragonfly#3283 ##### Huge thanks to all the contributors! ❤️ **Full Changelog**: dragonflydb/dragonfly@v1.19.0...v1.20.0 </details>  Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>

#845) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly) | minor | `v1.19.2` -> `v1.20.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dragonflydb/dragonfly (ghcr.io/dragonflydb/dragonfly)</summary> ### [`v1.20.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.0) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.19.2...v1.20.0) ##### Dragonfly v1.20.0 Some prominent changes include: - Improvements around client side caching ([#3136](https://togithub.com/dragonflydb/dragonfly/issues/3136) [#3158](https://togithub.com/dragonflydb/dragonfly/issues/3158)) Specifically, rueidis is now supported ([#2454](https://togithub.com/dragonflydb/dragonfly/issues/2454)) - Improvements around search and vector search APIs, FT.ALTER is now supported ([#3144](https://togithub.com/dragonflydb/dragonfly/issues/3144), [#3148](https://togithub.com/dragonflydb/dragonfly/issues/3148), [#3178](https://togithub.com/dragonflydb/dragonfly/issues/3178), [#3186](https://togithub.com/dragonflydb/dragonfly/issues/3186)) - JSON.MSET is added ([#3167](https://togithub.com/dragonflydb/dragonfly/issues/3167)) - Expiry notifications are now supported ([#3154](https://togithub.com/dragonflydb/dragonfly/issues/3154)) ##### What's Changed - test(cluster_mgr): Add tests for cluster_mgr.py by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3129 - chore: get rid of kv_args and replace it with slices to full_args by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3101 - fix: Fix live-lock in connection test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3135 - chore: call breaker_cb\_ on shutdown by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3128 - chore: Add option to disable aws dependency by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3077 - feat(cluster): Add important logs by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3138 - chore: a small cleanup by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3140 - test: skip test_cluster_migration_cancel, it is broken by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3146 - chore: update helio by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3150 - fix: fix bug in cluster/slot_set by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3143 - chore: recommit client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3136 - feat(search): Tag field options (separator, case sensitivity) by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3144 - feat(search): basic FT.ALTER by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3148 - chore: Introduce pipeline back-pressure by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3152 - fix: lua and client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3163 - feat: client tracking optout by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3158 - feat: add noloop subcommand in client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3164 - fix(ci): docker not using iouring by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3169 - fix(ci): add missing docker option on reg tests workflow by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3172 - fix: acl compatibility by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3147 - chore: Streamer is rewritten with async interface by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3108 - feat(json): MSET by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3167 - fix(cluster): Wait for flow creation before cancelling it by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3159 - chore: improve ft.create for vector search by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3178 - feat: add incoming migration error processing by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3175 - chore: add parsing support for the rest of VECTOR parameters by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3179 - fix(cluster): Wait before all access to slot migrations by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3180 - fix(server): fix bug in replication on cached mode by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3156 - chore: small acl compat changes by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3177 - chore: allow calling Context::ReportError from I/O dispatch fiber by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3182 - chore: add a lexer test covering KNN query by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3185 - chore(search): Add \__vector_score alias by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3186 - chore: Refactor string span management by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3165 - chore(ci): run replication tests on arm by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3168 - chore(search): improve parser error reporting by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3184 - fix(reply_builder): remove virtual modifier in SendError(ErrorReply) method by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3191 - fix(cluster): Support `FLUSHALL` while slot migration is in progress by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3173 - fix: fix RegisterOnChange methods for journal and db_slice by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3171 - fix(generic_family): fix RenameGeneric command for non-string data types by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3181 - fix(server): Rename confusing flag `replica_reconnect_on_master_restart` by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3193 - fix(unit tests): fix generic family info test by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3187 - test: improve cluster_fuzzy_migration test by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3197 - chore(core): Remove DfImpl inside ScoredMap by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3199 - chore(tiering): Remove IoMgr by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3198 - test(cluster): Make sure migration maintains TTL by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3188 - feat(cluster): Support `STICK` bit in slot migration by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3200 - chore: Re-enable previously flaky test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3196 - feat(acl): add support of multiple passwords by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3189 - chore(tiering): More advanced tiering tests by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3201 - chore: add replica-priority flag by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3204 - chore: fix tiering regtest test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3208 - feat(generic_family): Assemble RESTORE and STICK commands into one commmand during replication of the RENAME command by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3209 - core(search): Add EF_RUNTIME parameter by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3206 - fix(sanitizers): failing json test by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3176 - feat(server): expiry notifications by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3154 - fix: replicaof_reject_on_load flake by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3203 - fix(cluster): Don't miss keys when migrating slots by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3218 - fix(tiering): Fix pending leak during immediate stash error by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3219 - chore: provide basic logging to catch possible command errors by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3213 - chore: disable tiering test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3236 - fix(transaction): Don't transactionalize empty EVAL inside EXEC by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3231 - fix: fix deadlock in DFLYCLUSTER CONFIG command and outgoing migration finaliztion by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3239 - chore(tiered): minor fixes + expose buffer allocation type stats by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3234 - fix(pytest): timed ticker for simpler conditions by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3242 - fix(server): Fix SCAN deadlock by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3235 - chore: introduce back-pressure to tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3243 - chore: improve dfly_bench by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3244 - chore(tiering): External alloc free page chaining by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3237 - fix: total_stash_overflows statistic by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3248 - chore: update action versions by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3250 - chore(lua): Return which undeclared key was accessed by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3245 - chore: replace session wide fixtures with scope by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3251 - chore: pull helio and adjust mimalloc for 32MiB segments by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3174 - chore: add more logs around the duplicate value case in small_bins by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3254 - fix: fix move error during migration finalization by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3253 - chore: upload all the logs from /tmp by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3263 - fix(tiering): Throttle snapshot load by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3249 - chore: initiate grow preemptively by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3267 - chore(monitoring): add more dashboards + memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3268 - fix(json_family): fix JSON.GET commmand for JSON legacy mode by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3261 - chore: dfly_bench can send traffic to memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3271 - chore: print effective QPS of the server. by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3274 - chore: debugging fixes by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3275 - chore: more debug checks around tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3277 - chore(license): Fix typo in LICENSE.md text by [@softmoth](https://togithub.com/softmoth) in [dragonflydb/dragonfly#3283 - fix(test): Verify that save has not finished by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3278 - Create scorecard.yml by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3270 - chore: Disable cluster_mgr_test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3279 - fix: Increase key count to make test more robust by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3286 - fix: properly clean tiered state upon flash by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3281 - fix(bug): crash on takeover and info replication by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3282 ##### New Contributors - [@softmoth](https://togithub.com/softmoth) made their first contribution in [dragonflydb/dragonfly#3283 ##### Huge thanks to all the contributors! ❤️ **Full Changelog**: dragonflydb/dragonfly@v1.19.0...v1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

…nfly ( v1.19.2 → v1.20.1 ) (#762) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.dragonflydb.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly) | minor | `v1.19.2` -> `v1.20.1` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly (docker.dragonflydb.io/dragonflydb/dragonfly)</summary> ### [`v1.20.1`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.1) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.20.0...v1.20.1) ##### Dragonfly v1.20.1 This is a patch release. fix: S3 access for loading/saving snapshots ([#3296](https://togithub.com/dragonflydb/dragonfly/issues/3296)) Signed-off-by: kostas <[email protected]> ### [`v1.20.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.0) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.19.2...v1.20.0) ##### Dragonfly v1.20.0 Some prominent changes include: - Improvements around client side caching ([#3136](https://togithub.com/dragonflydb/dragonfly/issues/3136) [#3158](https://togithub.com/dragonflydb/dragonfly/issues/3158)) Specifically, rueidis is now supported ([#2454](https://togithub.com/dragonflydb/dragonfly/issues/2454)) - Improvements around search and vector search APIs, FT.ALTER is now supported ([#3144](https://togithub.com/dragonflydb/dragonfly/issues/3144), [#3148](https://togithub.com/dragonflydb/dragonfly/issues/3148), [#3178](https://togithub.com/dragonflydb/dragonfly/issues/3178), [#3186](https://togithub.com/dragonflydb/dragonfly/issues/3186)) - JSON.MSET is added ([#3167](https://togithub.com/dragonflydb/dragonfly/issues/3167)) - Expiry notifications are now supported ([#3154](https://togithub.com/dragonflydb/dragonfly/issues/3154)) ##### What's Changed - test(cluster_mgr): Add tests for cluster_mgr.py by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3129 - chore: get rid of kv_args and replace it with slices to full_args by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3101 - fix: Fix live-lock in connection test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3135 - chore: call breaker_cb\_ on shutdown by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3128 - chore: Add option to disable aws dependency by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3077 - feat(cluster): Add important logs by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3138 - chore: a small cleanup by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3140 - test: skip test_cluster_migration_cancel, it is broken by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3146 - chore: update helio by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3150 - fix: fix bug in cluster/slot_set by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3143 - chore: recommit client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3136 - feat(search): Tag field options (separator, case sensitivity) by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3144 - feat(search): basic FT.ALTER by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3148 - chore: Introduce pipeline back-pressure by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3152 - fix: lua and client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3163 - feat: client tracking optout by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3158 - feat: add noloop subcommand in client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3164 - fix(ci): docker not using iouring by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3169 - fix(ci): add missing docker option on reg tests workflow by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3172 - fix: acl compatibility by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3147 - chore: Streamer is rewritten with async interface by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3108 - feat(json): MSET by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3167 - fix(cluster): Wait for flow creation before cancelling it by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3159 - chore: improve ft.create for vector search by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3178 - feat: add incoming migration error processing by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3175 - chore: add parsing support for the rest of VECTOR parameters by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3179 - fix(cluster): Wait before all access to slot migrations by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3180 - fix(server): fix bug in replication on cached mode by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3156 - chore: small acl compat changes by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3177 - chore: allow calling Context::ReportError from I/O dispatch fiber by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3182 - chore: add a lexer test covering KNN query by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3185 - chore(search): Add \__vector_score alias by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3186 - chore: Refactor string span management by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3165 - chore(ci): run replication tests on arm by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3168 - chore(search): improve parser error reporting by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3184 - fix(reply_builder): remove virtual modifier in SendError(ErrorReply) method by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3191 - fix(cluster): Support `FLUSHALL` while slot migration is in progress by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3173 - fix: fix RegisterOnChange methods for journal and db_slice by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3171 - fix(generic_family): fix RenameGeneric command for non-string data types by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3181 - fix(server): Rename confusing flag `replica_reconnect_on_master_restart` by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3193 - fix(unit tests): fix generic family info test by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3187 - test: improve cluster_fuzzy_migration test by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3197 - chore(core): Remove DfImpl inside ScoredMap by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3199 - chore(tiering): Remove IoMgr by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3198 - test(cluster): Make sure migration maintains TTL by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3188 - feat(cluster): Support `STICK` bit in slot migration by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3200 - chore: Re-enable previously flaky test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3196 - feat(acl): add support of multiple passwords by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3189 - chore(tiering): More advanced tiering tests by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3201 - chore: add replica-priority flag by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3204 - chore: fix tiering regtest test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3208 - feat(generic_family): Assemble RESTORE and STICK commands into one commmand during replication of the RENAME command by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3209 - core(search): Add EF_RUNTIME parameter by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3206 - fix(sanitizers): failing json test by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3176 - feat(server): expiry notifications by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3154 - fix: replicaof_reject_on_load flake by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3203 - fix(cluster): Don't miss keys when migrating slots by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3218 - fix(tiering): Fix pending leak during immediate stash error by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3219 - chore: provide basic logging to catch possible command errors by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3213 - chore: disable tiering test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3236 - fix(transaction): Don't transactionalize empty EVAL inside EXEC by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3231 - fix: fix deadlock in DFLYCLUSTER CONFIG command and outgoing migration finaliztion by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3239 - chore(tiered): minor fixes + expose buffer allocation type stats by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3234 - fix(pytest): timed ticker for simpler conditions by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3242 - fix(server): Fix SCAN deadlock by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3235 - chore: introduce back-pressure to tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3243 - chore: improve dfly_bench by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3244 - chore(tiering): External alloc free page chaining by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3237 - fix: total_stash_overflows statistic by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3248 - chore: update action versions by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3250 - chore(lua): Return which undeclared key was accessed by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3245 - chore: replace session wide fixtures with scope by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3251 - chore: pull helio and adjust mimalloc for 32MiB segments by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3174 - chore: add more logs around the duplicate value case in small_bins by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3254 - fix: fix move error during migration finalization by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3253 - chore: upload all the logs from /tmp by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3263 - fix(tiering): Throttle snapshot load by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3249 - chore: initiate grow preemptively by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3267 - chore(monitoring): add more dashboards + memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3268 - fix(json_family): fix JSON.GET commmand for JSON legacy mode by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3261 - chore: dfly_bench can send traffic to memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3271 - chore: print effective QPS of the server. by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3274 - chore: debugging fixes by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3275 - chore: more debug checks around tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3277 - chore(license): Fix typo in LICENSE.md text by [@softmoth](https://togithub.com/softmoth) in [dragonflydb/dragonfly#3283 - fix(test): Verify that save has not finished by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3278 - Create scorecard.yml by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3270 - chore: Disable cluster_mgr_test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3279 - fix: Increase key count to make test more robust by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3286 - fix: properly clean tiered state upon flash by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3281 - fix(bug): crash on takeover and info replication by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3282 ##### New Contributors - [@softmoth](https://togithub.com/softmoth) made their first contribution in [dragonflydb/dragonfly#3283 ##### Huge thanks to all the contributors! ❤️ **Full Changelog**: dragonflydb/dragonfly@v1.19.0...v1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

…20.1 ) (#5021) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly) | minor | `v1.19.2` -> `v1.20.1` | --- ### Release Notes <details> <summary>dragonflydb/dragonfly (ghcr.io/dragonflydb/dragonfly)</summary> ### [`v1.20.1`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.1) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.20.0...v1.20.1) ##### Dragonfly v1.20.1 This is a patch release. fix: S3 access for loading/saving snapshots ([#3296](https://togithub.com/dragonflydb/dragonfly/issues/3296)) Signed-off-by: kostas <[email protected]> ### [`v1.20.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.20.0) [Compare Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.19.2...v1.20.0) ##### Dragonfly v1.20.0 Some prominent changes include: - Improvements around client side caching ([#3136](https://togithub.com/dragonflydb/dragonfly/issues/3136) [#3158](https://togithub.com/dragonflydb/dragonfly/issues/3158)) Specifically, rueidis is now supported ([#2454](https://togithub.com/dragonflydb/dragonfly/issues/2454)) - Improvements around search and vector search APIs, FT.ALTER is now supported ([#3144](https://togithub.com/dragonflydb/dragonfly/issues/3144), [#3148](https://togithub.com/dragonflydb/dragonfly/issues/3148), [#3178](https://togithub.com/dragonflydb/dragonfly/issues/3178), [#3186](https://togithub.com/dragonflydb/dragonfly/issues/3186)) - JSON.MSET is added ([#3167](https://togithub.com/dragonflydb/dragonfly/issues/3167)) - Expiry notifications are now supported ([#3154](https://togithub.com/dragonflydb/dragonfly/issues/3154)) ##### What's Changed - test(cluster_mgr): Add tests for cluster_mgr.py by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3129 - chore: get rid of kv_args and replace it with slices to full_args by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3101 - fix: Fix live-lock in connection test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3135 - chore: call breaker_cb\_ on shutdown by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3128 - chore: Add option to disable aws dependency by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3077 - feat(cluster): Add important logs by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3138 - chore: a small cleanup by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3140 - test: skip test_cluster_migration_cancel, it is broken by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3146 - chore: update helio by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3150 - fix: fix bug in cluster/slot_set by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3143 - chore: recommit client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3136 - feat(search): Tag field options (separator, case sensitivity) by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3144 - feat(search): basic FT.ALTER by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3148 - chore: Introduce pipeline back-pressure by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3152 - fix: lua and client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3163 - feat: client tracking optout by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3158 - feat: add noloop subcommand in client tracking by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3164 - fix(ci): docker not using iouring by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3169 - fix(ci): add missing docker option on reg tests workflow by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3172 - fix: acl compatibility by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3147 - chore: Streamer is rewritten with async interface by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3108 - feat(json): MSET by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3167 - fix(cluster): Wait for flow creation before cancelling it by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3159 - chore: improve ft.create for vector search by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3178 - feat: add incoming migration error processing by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3175 - chore: add parsing support for the rest of VECTOR parameters by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3179 - fix(cluster): Wait before all access to slot migrations by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3180 - fix(server): fix bug in replication on cached mode by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3156 - chore: small acl compat changes by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3177 - chore: allow calling Context::ReportError from I/O dispatch fiber by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3182 - chore: add a lexer test covering KNN query by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3185 - chore(search): Add \__vector_score alias by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3186 - chore: Refactor string span management by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3165 - chore(ci): run replication tests on arm by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3168 - chore(search): improve parser error reporting by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3184 - fix(reply_builder): remove virtual modifier in SendError(ErrorReply) method by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3191 - fix(cluster): Support `FLUSHALL` while slot migration is in progress by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3173 - fix: fix RegisterOnChange methods for journal and db_slice by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3171 - fix(generic_family): fix RenameGeneric command for non-string data types by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3181 - fix(server): Rename confusing flag `replica_reconnect_on_master_restart` by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3193 - fix(unit tests): fix generic family info test by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3187 - test: improve cluster_fuzzy_migration test by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3197 - chore(core): Remove DfImpl inside ScoredMap by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3199 - chore(tiering): Remove IoMgr by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3198 - test(cluster): Make sure migration maintains TTL by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3188 - feat(cluster): Support `STICK` bit in slot migration by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3200 - chore: Re-enable previously flaky test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3196 - feat(acl): add support of multiple passwords by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3189 - chore(tiering): More advanced tiering tests by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3201 - chore: add replica-priority flag by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3204 - chore: fix tiering regtest test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3208 - feat(generic_family): Assemble RESTORE and STICK commands into one commmand during replication of the RENAME command by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3209 - core(search): Add EF_RUNTIME parameter by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3206 - fix(sanitizers): failing json test by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3176 - feat(server): expiry notifications by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3154 - fix: replicaof_reject_on_load flake by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3203 - fix(cluster): Don't miss keys when migrating slots by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3218 - fix(tiering): Fix pending leak during immediate stash error by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3219 - chore: provide basic logging to catch possible command errors by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3213 - chore: disable tiering test by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3236 - fix(transaction): Don't transactionalize empty EVAL inside EXEC by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3231 - fix: fix deadlock in DFLYCLUSTER CONFIG command and outgoing migration finaliztion by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3239 - chore(tiered): minor fixes + expose buffer allocation type stats by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3234 - fix(pytest): timed ticker for simpler conditions by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3242 - fix(server): Fix SCAN deadlock by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3235 - chore: introduce back-pressure to tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3243 - chore: improve dfly_bench by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3244 - chore(tiering): External alloc free page chaining by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3237 - fix: total_stash_overflows statistic by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3248 - chore: update action versions by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3250 - chore(lua): Return which undeclared key was accessed by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3245 - chore: replace session wide fixtures with scope by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3251 - chore: pull helio and adjust mimalloc for 32MiB segments by [@kostasrim](https://togithub.com/kostasrim) in [dragonflydb/dragonfly#3174 - chore: add more logs around the duplicate value case in small_bins by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3254 - fix: fix move error during migration finalization by [@BorysTheDev](https://togithub.com/BorysTheDev) in [dragonflydb/dragonfly#3253 - chore: upload all the logs from /tmp by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3263 - fix(tiering): Throttle snapshot load by [@dranikpg](https://togithub.com/dranikpg) in [dragonflydb/dragonfly#3249 - chore: initiate grow preemptively by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3267 - chore(monitoring): add more dashboards + memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3268 - fix(json_family): fix JSON.GET commmand for JSON legacy mode by [@BagritsevichStepan](https://togithub.com/BagritsevichStepan) in [dragonflydb/dragonfly#3261 - chore: dfly_bench can send traffic to memcached by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3271 - chore: print effective QPS of the server. by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3274 - chore: debugging fixes by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3275 - chore: more debug checks around tiered storage by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3277 - chore(license): Fix typo in LICENSE.md text by [@softmoth](https://togithub.com/softmoth) in [dragonflydb/dragonfly#3283 - fix(test): Verify that save has not finished by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3278 - Create scorecard.yml by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3270 - chore: Disable cluster_mgr_test by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3279 - fix: Increase key count to make test more robust by [@chakaz](https://togithub.com/chakaz) in [dragonflydb/dragonfly#3286 - fix: properly clean tiered state upon flash by [@romange](https://togithub.com/romange) in [dragonflydb/dragonfly#3281 - fix(bug): crash on takeover and info replication by [@adiholden](https://togithub.com/adiholden) in [dragonflydb/dragonfly#3282 ##### New Contributors - [@softmoth](https://togithub.com/softmoth) made their first contribution in [dragonflydb/dragonfly#3283 ##### Huge thanks to all the contributors! ❤️ **Full Changelog**: dragonflydb/dragonfly@v1.19.0...v1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

fix(sanitizers): failing json test

c211b59

kostasrim commented Jun 14, 2024

View reviewed changes

src/core/json/lexer_impl.cc Show resolved Hide resolved

kostasrim requested review from romange and dranikpg June 14, 2024 09:07

turn off false positive

8fb1471

kostasrim self-assigned this Jun 14, 2024

romange reviewed Jun 14, 2024

View reviewed changes

kostasrim added 5 commits June 21, 2024 16:26

disable detect_stack_use_after_return

5970fa3

Merge branch 'main' into san_fix

0f849cb

disable stack use after scope

7cf1835

fixes

f34e5cb

revert

a9af19e

romange approved these changes Jun 24, 2024

View reviewed changes

kostasrim merged commit 3fd43ee into main Jun 24, 2024
11 checks passed

kostasrim deleted the san_fix branch June 24, 2024 10:12

kostasrim mentioned this pull request Aug 11, 2024

fix: sanitizers false positives #3495

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sanitizers): failing json test #3176

fix(sanitizers): failing json test #3176

kostasrim commented Jun 14, 2024

kostasrim commented Jun 14, 2024

romange Jun 14, 2024

kostasrim Jun 14, 2024

kostasrim Jun 21, 2024

romange commented Jun 14, 2024

kostasrim commented Jun 14, 2024

romange commented Jun 14, 2024

romange commented Jun 24, 2024

fix(sanitizers): failing json test #3176

fix(sanitizers): failing json test #3176

Conversation

kostasrim commented Jun 14, 2024

kostasrim commented Jun 14, 2024

romange Jun 14, 2024

Choose a reason for hiding this comment

kostasrim Jun 14, 2024

Choose a reason for hiding this comment

kostasrim Jun 21, 2024

Choose a reason for hiding this comment

romange commented Jun 14, 2024

kostasrim commented Jun 14, 2024

romange commented Jun 14, 2024

romange commented Jun 24, 2024