chore: change replica connect error log to WARN #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: reduce noise when performing H/A datastore update because we get spurious errors. We identify the disconnect event with metrics (by looking at master lag). Signed-off-by: Roman Gershman <[email protected]>
|
@romange how would you track multiple disconnect events on replication? if you have some kind of a bug in replication that causes replica to reconnect again and again. we have 0 lag in full sync mode |
|
True. In that case I would like the team to take over this PR and add the metric. Also maybe fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: reduce noise when performing H/A datastore update because we get spurious errors. We identify the disconnect event with metrics (by looking at master lag).