Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json_family): Add support of the JSON legacy mode #3224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BagritsevichStepan
Copy link
Contributor

@BagritsevichStepan BagritsevichStepan commented Jun 26, 2024

fixes #2959, fixes #1523

@BagritsevichStepan BagritsevichStepan self-assigned this Jun 26, 2024
@BagritsevichStepan BagritsevichStepan force-pushed the add_json_legacy_mod branch 4 times, most recently from 762969b to 550d97c Compare June 26, 2024 17:32
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this is a huge PR that is very hard to review.
I suggest you split it into series of 2 or more PRs where you converge gradually.
For example, to do code refactoring first without functional changes and then continue with changes.

@BagritsevichStepan
Copy link
Contributor Author

I wanted to split it into several commits, but PRs will be ok too.

I also think I should to create a separate file for JsonPath. And may be it will be good to change the class name, because it can be confused with json::Path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants