fix(transaction): Don't transactionalize empty EVAL inside EXEC #3231
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
fix-tx-exec-eval
branch
from
c19026e
to
8db28b9
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
reviewed
Jun 27, 2024
romange
approved these changes
Jun 28, 2024
adiholden
pushed a commit
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3230
Qucik fix. A bit ugly, because DetermineKeys works on a mutable span, so either we copy, or pass mutable 🤷🏻♂️
Reference #1444