feat(geo): add geosearchstore#4272
Closed
andydunstall wants to merge 1 commit intodragonflydb:mainfrom
andydunstall:add-geosearchstore
Closed
feat(geo): add geosearchstore#4272andydunstall wants to merge 1 commit intodragonflydb:mainfrom andydunstall:add-geosearchstore
andydunstall wants to merge 1 commit intodragonflydb:mainfrom
andydunstall:add-geosearchstore
Conversation
andydunstall
commented
Dec 7, 2024
| << CI{"GEOPOS", CO::FAST | CO::READONLY, -2, 1, 1, acl::kGeoPos}.HFUNC(GeoPos) | ||
| << CI{"GEODIST", CO::READONLY, -4, 1, 1, acl::kGeoDist}.HFUNC(GeoDist) | ||
| << CI{"GEOSEARCH", CO::READONLY, -4, 1, 1, acl::kGeoSearch}.HFUNC(GeoSearch) | ||
| << CI{"GEOSEARCHSTORE", CO::WRITE | CO::DENYOOM, -5, 1, 2, acl::kGeoSearchStore}.HFUNC( |
Contributor
Author
There was a problem hiding this comment.
I'm slightly guessing here about what CO:: params to use, not sure when CO::DENYOOM is needed etc - so just copied ZRANGESTORE which seems similar
Collaborator
|
I wish this was reviewed before the refactoring. @andydunstall I am sorry, could you please adjust your changes and ask @BorysTheDev / Adi for review? |
Contributor
Uh I am so sorry for this, I am happy to tag alone for help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3883.
Adds support for
GEOSEARCHSTORE. Follows the same approach as commands likeXREAD/XREADGROUPwith anotherFooGenericmethod (note the naming is a bit confusing we theres bothGeoSearchGenericandGeoSearchStoreGeneric, but still seems like the cleanest option)GeoSearchStoreGenericalready supports astoreoption so the changes here are small