feat(server): Journal omits#7060
Draft
dranikpg wants to merge 8 commits intodragonflydb:mainfrom
Draft
Conversation
dranikpg
force-pushed
the
new-journal-omits
branch
2 times, most recently
from
751383e to
cda32b8
Compare
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
new-journal-omits
branch
from
cda32b8 to
ffbdbf5
Compare
romange
reviewed
Apr 16, 2026
| bool expired_keys_events_recording_ = true; | ||
|
|
||
| // Provided for the next FindMutableInternal operation | ||
| MutationHints* mutation_hints_ = nullptr; |
Collaborator
There was a problem hiding this comment.
what is the size of MutationHints ? why do you need to pass by pointer and not by value?
looks fragile
Contributor
Author
There was a problem hiding this comment.
Because it is also used to get output variables
romange
reviewed
Apr 16, 2026
|
|
||
| bool HasRegisteredCallbacks() { | ||
| return journal_slice.HasRegisteredCallbacks(); | ||
| unsigned CallbackNumber() { |
Collaborator
There was a problem hiding this comment.
CallbackNumber is not a great name.
romange
reviewed
Apr 16, 2026
| } | ||
| } | ||
|
|
||
| DbSlice::MutationHints hints{.hint{.single_key = true, .support_omit = explicit_journal_}}; |
Collaborator
There was a problem hiding this comment.
can we do it more elegantly?
- at least in this example you pass hints with
.single_key = trueand setsupport_omitthen why passing them at all? why not pass a final boolean true if the caller supports omit - the boolean could be added to
op_args_.db_cntx, maybe so you won't need to inject this before the find call. skip_journal_can be returned by AddOrFind insideop_res.
Contributor
Author
There was a problem hiding this comment.
I agree, let's move it to existing structures
Signed-off-by: Vladislav <vlad@dragonflydb.io> Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
new-journal-omits
branch
from
7fdf5f8 to
99c0270
Compare
Signed-off-by: Vladislav <vlad@dragonflydb.io>
Contributor
Author
|
Will rebase to include #7253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental journal omits