Skip to content

chore(server): Extended SerializerBase test #7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dranikpg merged 4 commits into from
Apr 23, 2026
Merged

chore(server): Extended SerializerBase test #7179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d466705
chore(server): Extended SerializerBase test
dranikpg Apr 17, 2026
d6686fd
failing tiering test
dranikpg Apr 18, 2026
f19816b
fixes
dranikpg Apr 18, 2026
cef349c
fixes
dranikpg Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/server/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ helio_cxx_test(cluster/cluster_config_test dfly_test_lib LABELS DFLY)
helio_cxx_test(cluster/cluster_family_test dfly_test_lib LABELS DFLY)
helio_cxx_test(acl/acl_family_test dfly_test_lib LABELS DFLY)
helio_cxx_test(engine_shard_set_test dfly_test_lib LABELS DFLY)
helio_cxx_test(serializer_base_test dfly_test_lib LABELS DFLY)

add_dependencies(check_dfly dragonfly_test json_family_test list_family_test
generic_family_test memcache_parser_test rdb_test journal_test
Expand Down
3 changes: 3 additions & 0 deletions src/server/serializer_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
namespace dfly {

class ExecutionState;
struct TestDriver;

// Opaque identity for a physical DashTable bucket — its memory address.
// Unique across all databases/segments for the lifetime of a serialization.
Expand Down Expand Up @@ -66,6 +67,8 @@ struct DelayedEntryHandler {
}

private:
friend struct TestDriver;
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making DelayedEntryHandler befriend a test-only type (TestDriver) in a widely included production header effectively grants private access to any TU that defines dfly::TestDriver, which weakens encapsulation beyond just the test target.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown
Contributor Author

@dranikpg dranikpg Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but...


BucketDependencies& deps_;

// Entries that are waiting for tiered storage reads to complete before they can be serialized.
Expand Down
Loading
Loading