-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: do not commit #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.37-branch
Are you sure you want to change the base?
chore: do not commit #7191
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2681,6 +2681,7 @@ Connection::WaitEvent::WaitEvent(ParsedCommand* cmd, util::fb2::detail::Waiter* | |
| : key(cmd->Blocker()->OnCompletion(w)) { | ||
| } | ||
|
|
||
| // Dummt comment | ||
| void ResetStats() { | ||
| auto& cstats = tl_facade_stats->conn_stats; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PR title/description explicitly say "do not commit/do not merge" and don’t follow the repo’s PR guidelines for descriptive titles/summaries (Rule: AGENTS.md); you may want to close/convert this to a non-dummy PR before merging. Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| cstats.pipelined_cmd_cnt = 0; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added comment has a typo ("Dummt") and looks like an accidental/dummy change; keeping it in production code will add noise for future readers.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.