Skip to content

fix: slot redirection after takeover corrupted #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kostasrim wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: slot redirection after takeover corrupted #7263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/server/replica.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ std::error_code Replica::ConfigureDflyMaster() {
// We need to send this because we may require to use this for cluster commands.
// this reason to send this here is that in other context we can get an error reply
// since we are budy with the replication
RETURN_ON_ERR(SendCommandAndReadResponse(StrCat("REPLCONF CLIENT-ID ", id_)));
RETURN_ON_ERR(
SendCommandAndReadResponse(StrCat("REPLCONF CLIENT-ID ", service_.cluster_family().MyID())));
Copy link
Copy Markdown
Contributor Author

@kostasrim kostasrim May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MyId() falls back to replica id if the cluster_id flag is not set.

Comment on lines +422 to +423
Copy link
Copy Markdown
Collaborator

@romange romange May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. If cloud tests find this issue - we can cover this as well @kostasrim

Comment thread
romange marked this conversation as resolved.
if (!CheckRespIsSimpleReply("OK")) {
LOG(WARNING) << "Bad REPLCONF CLIENT-ID response";
}
Expand Down
Loading