Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafs: do not include chunk info array in the metadata blob #1157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiangliu
Copy link
Collaborator

Now we can reconstruct chunk info from RAFS v6 data blob with embedded chunk digest, so no need to embed the chunk info array in the metadata blob anymore, which helps to dramatically reduce size of metadata blob for big images.

@jiangliu jiangliu requested a review from a team as a code owner March 17, 2023 10:28
@jiangliu jiangliu requested review from bergwolf, luodw and adamqqqplay and removed request for a team March 17, 2023 10:28
@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/57322

@jiangliu jiangliu force-pushed the remove-chunk-info.patch branch from aa13eb5 to cf44b9b Compare March 17, 2023 10:34
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/57324

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@adamqqqplay adamqqqplay force-pushed the remove-chunk-info.patch branch from cf44b9b to 927f27f Compare April 21, 2023 07:50
Now we can reconstruct chunk info from RAFS v6 data blob with embedded
chunk digest, so no need to embed the chunk info array in the metadata
blob anymore, which helps to dramatically reduce size of metadata blob
for big images.

Signed-off-by: Jiang Liu <[email protected]>
@anolis-bot
Copy link
Collaborator

@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69235

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1157 (927f27f) into master (b937989) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   41.36%   41.35%   -0.01%     
==========================================
  Files         126      126              
  Lines       37336    37333       -3     
  Branches    37336    37333       -3     
==========================================
- Hits        15444    15440       -4     
- Misses      21157    21161       +4     
+ Partials      735      732       -3     
Impacted Files Coverage Δ
rafs/src/builder/core/v6.rs 31.67% <0.00%> (+0.11%) ⬆️
src/bin/nydus-image/main.rs 40.91% <0.00%> (ø)

... and 2 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@adamqqqplay
Copy link
Member

cargo-deny can be fixed in PR #1240

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants