This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Add the configuration options used by the plugin #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that change, VS Code would complain about unknown configuration options if those options were added to `settings.json`.
|
This was supposedly done already in #71 but I have no idea what happened to that commit. I can't find it in git history, even though the PR was merged. :-/ |
|
For some reason today the ensime language server refused to start when using this package.json with the current release, so remerging your change may be a better idea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that change, VS Code would complain about unknown configuration
options if those options were added to
settings.json.This is properly recognized by VS Code.
The CI failure seems unrelated.