Skip to content

Conversation

@drdhennessy
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

adding code amd answering assignment questions.

What did you learn from the changes you have made?

learned more about the python libraries.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I tried two different approaches for Q4 and reported them both.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

not really

How were these changes tested?

in python.

A reference to a related issue in your repository (if applicable)

n/a as of now

Checklist

  • [ X] I can confirm that my changes are working as intended

Copy link

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drdhennessy!
You're almost done! Just one small issue to address:

While calculating the mean of Petal Width, you are using the sample provided before bootstrapping.:
petal_widths = iris_df['petal width (cm)']
mean_petal_width = np.mean(petal_widths)

However, the task required calculating the mean of the bootstrapped samples like:
np.mean(bootstrapped_means)

Please make this correction and push the new commit. Then we’re done with LCR :)

Copy link

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drdhennessy

I checked once again, and due to some ambiguity in the task description, I have decided to approve your commit with the current implementation. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants