Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor sheet selection modules #2584

Open
wants to merge 30 commits into
base: dev
Choose a base branch
from
Open

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 21, 2024

close https://github.com/dream-num/univer-pro/issues/1260

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 18.43382% with 1177 lines in your changes missing coverage. Please review.

Project coverage is 26.37%. Comparing base (219a053) to head (aaf542f).
Report is 3 commits behind head on dev.

Files Patch % Lines
...ervices/selection/base-selection-render.service.ts 0.26% 381 Missing ⚠️
...src/services/selection/selection-render.service.ts 1.85% 106 Missing ⚠️
...s/render-services/ref-selections.render-service.ts 0.00% 99 Missing ⚠️
...ontrollers/defined-name/defined-name.controller.ts 0.00% 59 Missing ⚠️
...heets-formula/src/controllers/prompt.controller.ts 0.00% 41 Missing ⚠️
...ender-controllers/header-move.render-controller.ts 0.00% 32 Missing ⚠️
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 29 Missing ⚠️
...ender/src/render-manager/render-manager.service.ts 0.00% 27 Missing ⚠️
...s/sheets/src/services/selection-manager.service.ts 75.00% 27 Missing ⚠️
...sheets-ui/src/controllers/move-range.controller.ts 0.00% 23 Missing ⚠️
... and 95 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2584      +/-   ##
==========================================
- Coverage   27.00%   26.37%   -0.63%     
==========================================
  Files        1694     1699       +5     
  Lines       85220    85095     -125     
  Branches    17763    17716      -47     
==========================================
- Hits        23010    22442     -568     
- Misses      62210    62653     +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev changed the title refactor: remove enable merge cell API refactor: refactor sheet selection modules Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

View Deployment

#9722555522

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@wzhudev wzhudev marked this pull request as ready for review June 28, 2024 08:03
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Jun 28, 2024
@DR-Univer
Copy link
Collaborator

DR-Univer commented Jun 29, 2024

image
1、公式快捷键失效了,编辑框能输入= 或者 , 可以通过方向键继续新增选区。
2、跨子表选择范围后,确认输入,没有自动跳回当前子表。
dev分支是正常得

@univer-bot
Copy link

univer-bot bot commented Jun 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image

  1. The formula shortcut keys are invalid. You can enter = or in the edit box, and you can continue to add new selections through the arrow keys.
  2. After selecting a range across sub-tables, confirm the input and there will be no automatic jump back to the current sub-table.
    The dev branch is normal

@wzhudev
Copy link
Member Author

wzhudev commented Jun 29, 2024

image 1、公式快捷键失效了,编辑框能输入= 或者 , 可以通过方向键继续新增选区。 2、跨子表选择范围后,确认输入,没有自动跳回当前子表。 dev分支是正常得

OK,这应该是把公式选区移除出普通选区导致的,我改改

@univer-bot
Copy link

univer-bot bot commented Jun 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

![image](https://private-user-images.githubusercontent.com/68851825/344375773-b9d2afa0-64b6-4c73-bab6-e0fd4e7ae035.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.._176gS HUjfy3Bzf1d8EuYAPMq8hO-pdB5Y_pZRmUSHs) 1. Formula shortcut keys If it fails, you can enter = in the edit box. Or, you can use the arrow keys to continue adding new selections. 2. After selecting a range across sub-tables, confirm the input and there will be no automatic jump back to the current sub-table. The dev branch is normal

OK, this should be caused by removing the formula selection area from the ordinary selection area. I will change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants