0.4.8

- Adds a safety precaution that was added in 0.4.6 but was too greedy (#14)
dresende · Sep 27, 2016 · caf3f91 · caf3f91
1 parent f88df45
commit caf3f91
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/Client/ReadStream.js b/lib/Client/ReadStream.js
@@ -32,7 +32,8 @@ ReadStream.prototype._transform = function (chunk, encoding, next) {
 	while (this.pending.length >= 6) {
 		var pkg_len = this.pending.readUInt16BE(4) + 6;
 
-		if (this.pending.length < pkg_len) return next();
+		if (this.pending.length < 8)       return next(); // safety precaution
+		if (this.pending.length < pkg_len) return next(); // not all data yet
 
 		var data = this.pending.slice(8, pkg_len);
 		var pkg  = {

diff --git a/lib/Server/ReadStream.js b/lib/Server/ReadStream.js
@@ -32,7 +32,8 @@ ReadStream.prototype._transform = function (chunk, encoding, next) {
 	while (this.pending.length >= 6) {
 		var pkg_len = this.pending.readUInt16BE(4) + 6;
 
-		if (this.pending.length < pkg_len) return next();
+		if (this.pending.length < 8)       return next(); // safety precaution
+		if (this.pending.length < pkg_len) return next(); // not all data yet
 
 		var data = this.pending.slice(8, pkg_len);
 		var pkg  = {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name"            : "modbus-tcp",
-  "version"         : "0.4.7",
+  "version"         : "0.4.8",
   "description"     : "Modbus TCP/IP",
   "main"            : "lib/Modbus.js",
   "repository"      : "http://github.com/dresende/node-modbus-tcp.git",