Luke/dpe 1861 jito api changes #67
Conversation
|
|
||
| solEarned = solEarned.add( | ||
| currentLstTokenAmount.mul(currentLstRatioBN).div(LAMPORTS_PRECISION) | ||
| ); |
There was a problem hiding this comment.
Also not strictly specific to your PR, but I was also wondering if we should do the "sol earned" feature differently from a UX point of view.
I had a friend sort of get confused about what that even means, because there is no breakdown about where the sol earned is coming from or where it ends up. He thought he was getting sol that was claimable or added to his drift account or something lol.
I think we should work towards not showing a "sol earned" number necessarily, and instead showing a performance comparison of the user's current account value against the value of their initial deposit. That way it would factor out the "sol earned" that would have already been there if they had not been super staking at all.
Refactored / Updated LST methods to use data sourced from @glitchful-dev/sol-apy-sdk .. which according to person in jito is more of a standardised way to do things, and being used by Solana Compass already.
Can confirm that the APR/APYs values coming from this library are closer to the ones in Solana compass than the numbers we calculate locally with our own methods.