-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance asset-liability #7
Open
goldhaxx
wants to merge
9
commits into
drift-labs:master
Choose a base branch
from
goldhaxx:Risk-Dashboard-Trial-goldhaxx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance asset-liability #7
goldhaxx
wants to merge
9
commits into
drift-labs:master
from
goldhaxx:Risk-Dashboard-Trial-goldhaxx
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta validation. Added try-except for missing market data and improved column checks in the asset-liab matrix display. This ensures robustness against KeyErrors and provides user feedback when data is unavailable.
…page. Added try-except blocks for API calls, checks for valid response format, and warnings for empty data. Enhanced slot information retrieval with error handling.
goldhaxx
changed the title
Enhance asset-liability summary generation with error handling and data validation. Added try-except for missing market data and improved column checks in the asset-liab matrix display. This ensures robustness against KeyErrors and provides user feedback when data is unavailable.
Enhance asset-liability
Dec 21, 2024
… the presence of 'is_high_leverage' column. Added user feedback for unavailable data, improving robustness and user experience.
- Added volume mapping for logs in docker-compose.yml to persist log data. - Updated Dockerfile to create and set permissions for the /logs directory. - Replaced print statements with logging in asset_liability.py and matrix.py for better traceability and debugging. - Introduced timing metrics in asset_liability.py to monitor loading times and improve user feedback during data fetching and processing.
…anagement - Changed logging configuration in gunicorn_config.py to direct logs to /logs/access.log and /logs/error.log, and set log level to debug for improved debugging. - Added matrix_response.json and logs/* to .gitignore to prevent unnecessary files from being tracked. - Updated Streamlit config to suppress callback and resource warnings, enhancing user experience.
- Introduced a new attribute `last_oracle_slot` initialized to 0 in the BackendState class within state.py. This addition enhances the state management capabilities of the backend, potentially improving tracking of oracle data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance asset-liability.py summary generation with error handling and data validation. Added try-except for missing market data and improved column checks in the asset-liab matrix display. This ensures robustness against KeyErrors and provides user feedback when data is unavailable.
Fix Asset Liability Matrix Page Data Handling
Problem
The asset liability matrix page was crashing when encountering markets with missing data (specifically markets 29-32: META, ME, PENGU, and BONK). The page would attempt to access and sort by columns that didn't exist in the DataFrame, resulting in KeyErrors.
Changes
Specific Changes:
Testing
The page now: