Only URL encode data for GET requests#9
Open
npapadacis wants to merge 4 commits into
Open
Conversation
POST requests expect a JSON payload but that doesn't require URL encoding, in fact this will break any values that contain spaces, e.g., field names, etc. GET requests on the other hand will need the arguments to be URL encoded. The function that returns that data will now only URL encode if the request method is GET.
Colon is not allowed on Windows in a filename
setLogicalOperator can be specified in CWP for a FindCommand. The method was not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST requests expect a JSON payload but that doesn't require URL encoding, in fact this will break any values that contain spaces, e.g., field names, etc. GET requests on the other hand will need the arguments to be URL encoded. The function that returns that data will now only URL encode if the request method is GET.