Add release GitHub actions #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjkuch
force-pushed
the
317-ci-github
branch
from
b54aca6 to
f0bed51
Compare
pjbull
reviewed
Aug 12, 2024
…ing its parameter name rather than a fixed index
chrisjkuch
force-pushed
the
317-ci-github
branch
from
d3c6da1 to
2ea3c9a
Compare
jayqi
reviewed
Jan 3, 2025
pjbull
reviewed
Jan 28, 2025
| # Per #389, set this to the currently released version by default | ||
| param_names = [p.name for p in f.params] | ||
| checkout_index = param_names.index("checkout") | ||
| f.params[checkout_index].default = __version__ |
There was a problem hiding this comment.
It looks like some places (like the release tags), we use vX.Y.Z and others we use X.Y.Z. We should check if we need the v prefix here or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #317
closes #389
Add GitHub actions to publish on release
Do not merge - #315 is needed first. After transfer, the repo should automatically have access to the PyPI secrets needed byrelease.ymlccds.__version__Users can now see the version of
ccdsafter importing (ccds.__version__). However, the project name is different than the module name. This means that inversion.py, we have to hard code the project name with:Instead of using:
Using release version as default tag for checkout
Per #389, we wanted a way to allow more stable behavior when someone installs ccds. Currently, any change to the template on the master branch will automatically get propagated when someone runs ccds (unless the person has downloaded the template already and opts to skip that step). As part of this PR, we now default to ccds checking out the tag associated with the installed ccds version.
Users can always get the latest by checking out the master branch (
-c master) or updating ccds.Docs
This PR does not include versioning for docs (eg. with a "Build docs" job). That is tracked separately in #334