Skip to content

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Sep 15, 2025

  • Fix tests for Python 3.14
  • Add Python 3.14 to metadata
  • Fixes bug where typing or annotationlib would spuriously identified as the module for forward references in some cases

Copy link
Contributor

github-actions bot commented Sep 15, 2025

@github-actions github-actions bot temporarily deployed to pull request September 15, 2025 04:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 15, 2025 06:28 Inactive
@jayqi jayqi requested a review from Copilot September 15, 2025 15:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Python 3.14 by adapting to major typing system changes introduced in that version. Python 3.14 unified typing.Union and types.UnionType into a single implementation, making them indistinguishable and always rendering with | operator syntax.

  • Updates handling of union types to account for the unified implementation in Python 3.14
  • Fixes forward reference processing to prevent spurious module names
  • Removes deprecated ByteString mapping for Python 3.14+

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
typenames/init.py Updates union type detection logic and removes ByteString mapping for Python 3.14+
tests/test_typenames.py Adds version-specific test cases and regression test for forward reference bug
pyproject.toml Adds Python 3.14 classifier
README.md Documents Python 3.14 typing behavior changes
CHANGELOG.md Documents new features and bug fixes
.github/workflows/tests.yml Adds Python 3.14 to CI test matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pull request September 15, 2025 15:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 15, 2025 15:34 Inactive
@jayqi jayqi deployed to docs-preview September 15, 2025 15:34 — with GitHub Actions Active
@jayqi jayqi marked this pull request as ready for review September 15, 2025 15:36
@jayqi jayqi merged commit 197f983 into main Sep 15, 2025
2 checks passed
@jayqi jayqi deleted the py314 branch September 15, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant