-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for Python 3.14 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Deployed on https://typenames-pr17--preview-7c642f.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Python 3.14 by adapting to major typing system changes introduced in that version. Python 3.14 unified typing.Union
and types.UnionType
into a single implementation, making them indistinguishable and always rendering with |
operator syntax.
- Updates handling of union types to account for the unified implementation in Python 3.14
- Fixes forward reference processing to prevent spurious module names
- Removes deprecated
ByteString
mapping for Python 3.14+
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
typenames/init.py | Updates union type detection logic and removes ByteString mapping for Python 3.14+ |
tests/test_typenames.py | Adds version-specific test cases and regression test for forward reference bug |
pyproject.toml | Adds Python 3.14 classifier |
README.md | Documents Python 3.14 typing behavior changes |
CHANGELOG.md | Documents new features and bug fixes |
.github/workflows/tests.yml | Adds Python 3.14 to CI test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
typing
orannotationlib
would spuriously identified as the module for forward references in some cases