Surface the basic configuration with the user before proceeding with validation checking - Issue #196#322
Open
sambujangfofana wants to merge 1 commit intodrivendataorg:masterfrom
Open
Conversation
…validation checking Issue drivendataorg#196
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Looks like a reasonable first pass, needs a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #196,
@aaronphilip19 and I implemented this by defining the configuration file, data directory, csv file path, and the checkpoint based on user input and default values. We then prompted the user with a message through the command line interface asking them to review the basic configuration. If they answered yes, they would proceed with the validation; if they answered no, they had the option to change whatever they needed and to run the respective command (zamba predict or zamba train) through the terminal again.