Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set split proportions to None if split column is provided - Issue #198 #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set split proportions to None if split column is provided - Issue #198 #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions zamba/models/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,13 @@ def validate_filepaths_and_labels(cls, values):
)

elif values["split_proportions"] is not None:
logger.warning(
"Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence."
)
# set to None for clarity in final configuration.yaml
values["split_proportions"] = None
# Check to see if split_proportions contains the default values
if values.get("split_proportions") != {"train": 3, "val": 1, "holdout": 1}:
logger.warning(
"Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence."
)
# set to None for clarity in final configuration.yaml
values["split_proportions"] = None

# error if labels are entirely null
null_labels = labels.label.isnull()
Expand Down