[Pg] Add PostGIS MultiLineString support #2769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciabad
commented
Aug 8, 2024
| @@ -45,3 +45,64 @@ export function parseEWKB(hex: string): [number, number] { | |||
|
|
|||
| throw new Error('Unsupported geometry type'); | |||
| } | |||
|
|
|||
| export function parseMultiLineStringEWKB(hex: string): [number, number][][] { | |||
There was a problem hiding this comment.
Disclaimer: I did this function with AI, it may have mistakes. My PostgreSQL knowledge is not that deep to write it myself. 😅
mauriciabad
changed the title
mauriciabad
changed the title
mauriciabad
changed the title
|
I'm unable to run the tests. 😢 I'm following the guidelines (nvm use, open docker, pnpm i, pnpm build, cd integration-tests, pnpm test), but the It is not breaking due to my PR, because I'm runing the tests in main the branch. Could you (mantainers) run the tests in your computer, or help me run them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
MultiLineStringfrom PostGIS.Currently, the
geometrytype added in v0.31.0 only supportspoint, despite the documentation saying otherwise.I did this PR because I need a
MultiLineStringin my project, but if you come up with a way to support any PostGIS type, it would be awesome, meanwhile, adding the typemultilinestingmay be enough.The signature I defined is quite minimal and trivial, so if in the future you decide to internally implement PostGIS in a completely different way, it probably won't have breaking changes.