Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add VietName lunar calendar" #222

Closed
wants to merge 1 commit into from

Conversation

gouguoyin
Copy link
Collaborator

Reverts golang-module/carbon#221

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd4b00c) 100.00% compared to head (cceac42) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2563      2553   -10     
=========================================
- Hits          2563      2553   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@culy247
Copy link

culy247 commented Jan 31, 2024

@gouguoyin why merge and revert feature/vi-lunar branch?
Are there any problem with this branch?

@gouguoyin
Copy link
Collaborator Author

@gouguoyin why merge and revert feature/vi-lunar branch? Are there any problem with this branch?

Do not recalculate Julian days in the Gregorian calendar, use calendar/Julian pakage
for example

julian.FromGregorian(time.Date(year, time.Month(month), day, 0, 0, 0, 0, time.Local)).ToJulian().JD(0)

@gouguoyin gouguoyin closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants