Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add golangci-lint configuration #265

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ccoVeille
Copy link
Contributor

@ccoVeille ccoVeille commented Dec 9, 2024

204 issues:

  • dupword: 1
  • errcheck: 44
  • gci: 10
  • gosimple: 17
  • govet: 1
  • revive: 3
  • staticcheck: 2
  • testifylint: 124
  • unused: 2

This is the first iteration of #264

It can be merged it won't cause problem

You can launch golangci-lint locally and start fixing the issues one by one

$ golangci-lint run

204 issues:
* dupword: 1
* errcheck: 44
* gci: 10
* gosimple: 17
* govet: 1
* revive: 3
* staticcheck: 2
* testifylint: 124
* unused: 2
@gouguoyin gouguoyin merged commit 6473884 into dromara:master Dec 10, 2024
2 checks passed
@gouguoyin
Copy link
Collaborator

golangci-lint action still fails the test
https://github.com/dromara/carbon/actions/runs/12308019441

@ccoVeille
Copy link
Contributor Author

Sorting things is a journey, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants