Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a path of rev: or id: for get comands #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blakelauer
Copy link

The API allows for the download (get) command to use "path": "rev:a1c10ce0dd78" or "path": "id:a4ayc_80_OEAAAAAAAAAYa" but the validatePath function adds "/" to the path if it is not there. This
results in "path": "/rev:a1c10ce0dd78" and an error.

This change stops the "/" from being added if the path begins with "rev:" or "id:". This allows the command dbxcli get rev:a1c10ce0dd78 file.ext to run and download a specific revision of a file.

The API allows for the download (get) command to use "path":
"rev:a1c10ce0dd78" or "path": "id:a4ayc_80_OEAAAAAAAAAYa" but the
validatePath function adds "/" to the path if it is not there. This
results in "path": "/rev:a1c10ce0dd78" and an error.
@diwakergupta
Copy link
Collaborator

Thanks @blakelauer ! Can you also update the documentation to reflect this new capability?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants