Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed errors thrown by the fileURLToPath method (#6) #7

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Sep 5, 2023

Changes

fixed errors thrown by the fileURLToPath method (#6).

src/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You’re right—Rollup does all the resolution for us, so we don’t need to pull in the Vite config here. For some reason I was imagining resolving partial URLs myself but that’s not needed here.

@drwpow
Copy link
Owner

drwpow commented Sep 5, 2023

If you could also add a patch changeset note (run npx changeset in the root), that will bump the version, update the changelog, and deploy a new version to npm

@drwpow drwpow mentioned this pull request Sep 5, 2023
optimized code

Co-authored-by: Drew Powers <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: 0e6e2ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-lqip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@drwpow drwpow merged commit 9f18fd4 into drwpow:main Sep 6, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants