This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Make TTURLImageResponse respect cachePolicy when loading images #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Give the user the possibility to configure the Requester before TTImageView make the call to the server.
In -model:didInsertObject:atIndexPath: of TTTableViewController, the -scrollToRowAtIndexPath:atScrollPosition:animated: message was send to the tableView whenever a new row was inserted. This is not going to work if the new row was inserted as part of a larger change, i.e. if -beginUpdates was called on the tableView and some new sections were inserted prior to inserting the row. In addition, scrolling to arbitrary rows without explicit control from the App developer isn't good practice either, so just ditch the scroll code all together.
- 'textAlign' method format UITextAlignment based on 'text_align'. - Beatifully validate some CSS values.
- 'text-shadow-opacity' for text shadows opacity. - 'TTCSSApplyProtocol' as a common interface to UI components apply styles from CSS. - UIView implementation of TTCSSApplyProtocol. - UILabel implementation of TTCSSApplyProtocol.
…ity properties. - UIView format itself with this properties.
…maximum length of line that would be allowed.
Updates to the lint script - Check for Copy Headers phase. - --maxline option for overriding the default line length (100).
New method setCenterPageIndex:animated: allows change the visible page with one optional animation. Also the centerPageAnimationDuration property allows the user to configure the duration of this animation. Limitation (to be improved): Only animate if the distance between the actual page and the informed one. Example: If is one page 1 and you inform page 3, will not animate.
…e delegate. Why he don't it before??
commit 8da50f3e9aa331f5b67f617b437ba8f8c12f1a0b Merge: 4cc9eed 8537f33 Author: John Wang <[email protected]> Date: Sat Jul 9 08:29:17 2011 -1000 Merge branch 'issue224requestTimeout' of https://github.com/tonklon/three20 into tonklon-issue224requestTimeout Conflicts: src/Three20Network/Headers/TTURLRequest.h src/Three20Network/Sources/TTURLRequest.m src/Three20Network/Three20Network.xcodeproj/project.pbxproj commit 8537f33 Author: Tobias Klonk <[email protected]> Date: Fri Feb 11 13:05:01 2011 +0100 [Network] renamed TTURLRequestUseDefaultTimeout to TTURLRequestUseQueueTimeout commit 604a5fa Author: Tobias Klonk <[email protected]> Date: Thu Feb 10 23:26:16 2011 +0100 added configurable request timeouts #fixes 224
Czech Localization
…fb98ca4dd7a265531d5036e performance enhanced for scrollviews that use TTPhotoView with images stored on-device
…workspace add Xcode 4 workspace
[UI] Reload buttons in TTTableViewController error views
…crashfix TTTableView shadow crash fix
make pointer to NSString's const, not the pointee. Then those strings can be used without copying (and all the mem leaks are fixed)
LLVM ARM6 release build optimizer bug...
(was json)
see #769 for the related issue
[Release] Three20 1.0.11
…able cell This functionality is implemented in TTTableLinkedItemCell.m, in setObject. Remember, TTTableLinkedItemCell is a subclass of UITableViewCell, and so this is where you actually control what kind of table cell is created. Also remember that TTTableLinkedItemCell is the class that is created when you add a TTTableLinkedItem (or one of it's numerous subclasses) to the table in your TTTableDatasource class. The rules here are: - if the TTTableLinkedItem has an accessoryURL, then: a) accessoryType => UITableViewCellAccessoryDetailDisclosureButton - if the navigationMode for the URL associated with the TTTableLinkedItem is (TTNavigationModeCreate || TTNavigationModeShare), then: b)accessoryType => UITableViewCellAccessoryDisclosureIndicator This is sensible, but what if you set a URL for the TTTableLinkedItem, and it still doesn't appear? Probably it is returning TTNavigationModeNone, which is in turn b/c TTNavigator is not usefully documented. Here's one way to cause that: use TTURLMap from:toObject:selector:, like this: TTNavigator* navigator = [TTNavigator navigator]; TTURLMap* map = navigator.URLMap; [map from:@"drync://tag_custom_location" toObject:self selector:@selector(tag_custom_location) ]; Note: if you use other variants in TTURLMap, like the toViewController/toSharedViewController/toModalViewController variants, then the issue doesn't arise. The problem is exactly if you want to carefully control the creation of the view controller, perhaps because you need to interface to an old-style, non-three20 view. Ended out patching TTUrlMap as follows to allow TTNavigationMode to be specified, if you care to.
…ses. - The individual item objects can understand their cell representation class, avoiding the need for a subclass of TTTableViewDataSource - The constructor of a datasource can specify mapping, obviating need for a custom datasource class or even a tableitem class at all.
gloriaannehedlund
pushed a commit
that referenced
this pull request
Apr 11, 2012
Adding documentation on when to set the tableBannerView within the view's life cycle.
UITouch ivars have been removed of the iOS 6 SDK headers: private API access in UIViewAdditions breaks the build on iOS 6. The flag to activate the UITouch extensions is now more strict, so that it is not enabled by default in debug builds, and require an explicit setting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a TTURLImageRequest to grab images that change frequently, and specify TTURLRequestCachePolicyNoCache. This fix makes the TTURLImageResponse respect that specification.