set deleted to false instead of unsetting when calling restore()#150
Merged
dsanel merged 1 commit intodsanel:masterfrom Nov 6, 2025
Merged
set deleted to false instead of unsetting when calling restore()#150dsanel merged 1 commit intodsanel:masterfrom
dsanel merged 1 commit intodsanel:masterfrom
Conversation
Contributor
|
I put up another PR that does this before seeing yours. Apologies. Here's mine: #157 |
Contributor
Author
|
@dsanel would you be open to transferring this project to the mongoosejs GitHub org and handing maintenance over to the Mongoose team? No pressure, this is your project if you want to keep maintaining it, I wanted to ask just in case. |
Contributor
Author
|
Hi, just following up on this PR. Is there anything blocking merging and releasing this PR? |
Contributor
|
I'd consider merging the one I opened because this one is not as robust as it doesn't check the status of |
Contributor
|
But honestly, there's been no response on any issues or PRs in a long time so I think this package needs to be forked by the community at this point. |
Owner
|
@vkarpov15 Thx!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Automattic/mongoose#14338
It looks like this commit: b8c3cea made it so that the
restore()static would unsetdeletedversus setting it tofalse, which is backwards breaking for projects that useuse$neOperator: false.