forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
LPD-38587 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianchandotcom
wants to merge
1,428
commits into
dsanz:master
Choose a base branch
from
brianchandotcom:pull-request-166287-LPD-38587
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPD-38587 #100
brianchandotcom
wants to merge
1,428
commits into
dsanz:master
from
brianchandotcom:pull-request-166287-LPD-38587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortlet_LayoutSetLayoutsPortlet
# breaking ## What modules/apps/layout/layout-admin-api/src/main/java/com/liferay/layout/admin/constants/LayoutAdminPortletKeys.java A new constant LAYOUT_SET_LAYOUTS was added. ## Why A new portlet called LayoutSetLayoutsPortlet has been created to provide batch export/import support for the pages of a site. ----
# breaking ## What modules/apps/export-import/export-import-test/src/testIntegration/java/com/liferay/exportimport/internal/data/handler/test/BatchEnginePortletDataHandlerTest.java The methods of ExportImportDescriptor subclass has been changed. ## Why To provide better capabilities for batch support. For example, getParameters(com.liferay.exportimport.kernel.lar.PortletDataContext) now can be used to add parameters depending on the PortletDataContext. While isActive(com.liferay.exportimport.kernel.lar.PortletDataContext) can decide whether or not to execute batch processes, based on conditions depending on the PortletDataContext. ----
…g settings can produce this scenario
…rImpl # Conflicts: # modules/apps/object/object-rest-impl/src/main/java/com/liferay/object/rest/internal/manager/v1_0/DefaultObjectEntryManagerImpl.java
…ocalServiceImpl note: here its change of behavior, suffix "copy" will be added by default
…tionLocalServiceImpl note: here its change of behavior, suffix "copy" will be added by default
note: here its change of behavior, suffix "copy" will be added by default
note: here its change of behavior, suffix "copy" will be added by default
…e them in the interpolation. First, interpolate provided tokens, then resolvers, then default tokens
…solutions. Use token interpolation in FDS serializers
…s, using a new tokenResolutions property
…PI URL separately, in preparation for usages in the Data Set Fragment. Implement the new method using provided token resolutions
…, to get the original URL or the interpolated one
… interfaces and implementations. Keep default behavior # breaking ## What modules/apps/frontend-data-set/frontend-data-set-api/src/main/java/com/liferay/frontend/data/set/renderer/FDSRenderer.java Added new method getFDSAPIURL, which calculates the API URL and optionally interpolates tokens in it. Interpolation is done with data from the underlying infrastructure, and now, also from an optional set of resolved tokens ## Why This method is needed to support on-the-fly URL interpolation feature in the Data Set fragment ---- # breaking ## What modules/apps/frontend-data-set/frontend-data-set-api/src/main/java/com/liferay/frontend/data/set/serializer/FDSSerializer.java Added new variants for methods serializeAPIURL and serializeAdditionalAPIURLParameters, allowing renderer to serialize API url components with or without token interpolation, and also, to provide a set of resolved tokens for serialization ## Why These methods are needed to support new capability in FDSRendered, related with on-the-fly URL interpolation from Data Set fragment ----
…ed tokens in the REST endpoint when FF is activated
…UI and allow user to map them. Use the provided tokens from fragment editables to render the FDS
Collaborator
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.