ADServicePrincipalName: Call test at the top of set in case of explic…

…it call to set function (#707)
dsccommunity · Apr 8, 2024 · bdde66f · bdde66f
1 parent a74448e
commit bdde66f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
 
 ## [Unreleased]
 
+### Changed
+
+- ADServicePrincipalName
+  - Add check to Set function to cover if `Invoke-DscResource -Method Set` is run and no changes are required.
+    ([issue #520](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/520))
+
 ## [6.4.0] - 2024-02-14
 
 ### Added

diff --git a/source/DSCResources/MSFT_ADServicePrincipalName/MSFT_ADServicePrincipalName.psm1 b/source/DSCResources/MSFT_ADServicePrincipalName/MSFT_ADServicePrincipalName.psm1
@@ -94,6 +94,13 @@ function Set-TargetResource
         $Account
     )
 
+    # Test if the resource needs changing if called with Invoke-DscResource -Method Set
+    $inDesiredConfiguration = Test-TargetResource @PSBoundParameters
+    if ($inDesiredConfiguration)
+    {
+        return
+    }
+
     # Get all Active Directory object having the target SPN configured.
     $spnAccounts = Get-ADObject -Filter { ServicePrincipalName -eq $ServicePrincipalName } -Properties 'SamAccountName', 'DistinguishedName'