Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest CI pipeline pattern - Fixes #528 #529

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jun 1, 2024

Pull Request (PR) description

This PR updates the pipeline and supporting files to the latest DSC Community pattern. It also updates the build and HQRM VM images to run on windows-latest

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).

Remaining N/A

  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (9d6e70d) to head (b1d83bb).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #529   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2078           
===================================
+ Hits       2028   2029    +1     
+ Misses       50     49    -1     

see 1 file with indirect coverage changes

@PlagueHO
Copy link
Member Author

PlagueHO commented Jun 1, 2024

@johlju - would you mind reviewing when you get a chance? This is just a pipeline update and will unblock #526 and #523

@PlagueHO
Copy link
Member Author

PlagueHO commented Jun 1, 2024

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jun 2, 2024
@PlagueHO PlagueHO requested a review from johlju June 2, 2024 05:07
@PlagueHO
Copy link
Member Author

PlagueHO commented Jun 2, 2024

Not sure why LoopbackAdapter package isn't being installed/found....

/AzurePipelines run

@PlagueHO
Copy link
Member Author

PlagueHO commented Jun 2, 2024

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 9 files at r1, 1 of 2 files at r2, 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit e8b5edc into dsccommunity:main Jun 7, 2024
11 checks passed
@johlju johlju removed the needs review The pull request needs a code review. label Jun 7, 2024
@PlagueHO PlagueHO deleted the Issue-528 branch June 7, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pipeline Files to Latest DSC Community and Sampler pattern
2 participants