Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly upload gzipped files #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

urbany
Copy link

@urbany urbany commented Dec 15, 2016

Fixes #26

Added a config gzippedFiles, which by default is context.gzippedFiles (provided by ember-cli-deploy-gzip).

We need to wait until getsentry/sentry#4677 is merged and deployed to properly test this.

@urbany urbany force-pushed the fix-26-correctly-upload-gzipped-files branch from 47203ad to 39c1da0 Compare December 15, 2016 11:58
@urbany urbany force-pushed the fix-26-correctly-upload-gzipped-files branch from f3086f9 to a072078 Compare December 15, 2016 12:04
@kmiyashiro
Copy link
Contributor

getsentry/sentry#4677 has been merged

@dschmidt
Copy link
Owner

Habe you had a chance to test this?

@kmiyashiro
Copy link
Contributor

Looks like something went wrong with getsentry/sentry#4566 (comment)

@urbany
Copy link
Author

urbany commented Dec 16, 2016

@dschmidt I tested that the request is properly sending the content-encoding: gzip header for the files present in context.gzippedFiles but haven't tested it with sentry.io yet since it isn't fixed on their side.

@joshsmith
Copy link

@urbany is this deployed now on sentry.io?

@urbany
Copy link
Author

urbany commented Jan 26, 2017

@joshsmith there's been no updates from sentry.io since my last comment. Still waiting.

@dschmidt
Copy link
Owner

Woah, the situation is very sad. I will take care that we get a workaround soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants