Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Commit

Permalink
Modified the production bundles location (fixes #91)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsebastien committed Jan 24, 2016
1 parent 4c8cd39 commit b3dd8a6
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 27 deletions.
34 changes: 18 additions & 16 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
@@ -1,28 +1,30 @@
* 0.3.2
* Fixed production bundles paths (css, js) (fixes #91)
* 0.3.1
* made JSPM optional (closes #77)
* JSPM remains used by default but you can now customize the behavior by setting the useJSPM option to false
* if you disable JSPM then you can provide a custom name for the configuration file (the build defaults to jspm.conf.js)
* JSPM remains used by default but you can now customize the behavior by setting the useJSPM option to false
* if you disable JSPM then you can provide a custom name for the configuration file (the build defaults to jspm.conf.js)
* fixed an issue with the tasks chaining (callbacks were used needlessly) (closes #89)
* upgraded the version of SystemJS-builder (closes #87)
* 0.3.0
* Breaking change: improved integration with tsconfig.json (see #72)
* this might impact existing projects
* before, the list of folders to include in TS compilation were hardcoded. Now, the tsconfig.json file is used, thus you have more control (but also more responsibility)
* this might impact existing projects
* before, the list of folders to include in TS compilation were hardcoded. Now, the tsconfig.json file is used, thus you have more control (but also more responsibility)
* removed mentions of tsd. My current recommendation is to use `typings`, although there's nothing forcing you to with the build
* https://github.com/typings/typings
* https://angularclass.com/the-state-of-typescript-packages/
* https://github.com/typings/typings
* https://angularclass.com/the-state-of-typescript-packages/
* upgraded dependencies
* Babel dependencies 6.3.x to 6.4.x
* autoprefixer 6.1.x to 6.2.x
* Babel dependencies 6.3.x to 6.4.x
* autoprefixer 6.1.x to 6.2.x
* Known issues
* #76: there is an issue with the way that gulp-typescript (the plugin used within the scripts-typescript gulp task) handles the 'rootDir' property, which is inconsistent with tsc.
* to solve this, for now you need to add a reference to the main typings file of your project; Example:
```
/// <reference path="../../typings/main.d.ts" />
```
* the final solution might come via the following issues and might require a new release of this project
* https://github.com/ivogabe/gulp-typescript/issues/190
* https://github.com/typings/typings/issues/69
* #76: there is an issue with the way that gulp-typescript (the plugin used within the scripts-typescript gulp task) handles the 'rootDir' property, which is inconsistent with tsc.
* to solve this, for now you need to add a reference to the main typings file of your project; Example:
```
/// <reference path="../../typings/main.d.ts" />
```
* the final solution might come via the following issues and might require a new release of this project
* https://github.com/ivogabe/gulp-typescript/issues/190
* https://github.com/typings/typings/issues/69
* 0.2.3
* fixed sourcemap generation issues (see #69)
* sourcemaps sometime require a browser refresh before actually working: this might be due to a related issue (timing issue?)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "modern-web-dev-build",
"description": "Modern Web Development Build.",
"version": "0.3.1",
"version": "0.3.2",
"author": {
"name": "Sebastien Dubois",
"email": "[email protected]",
Expand Down
23 changes: 13 additions & 10 deletions src/gulp/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ let folders = {
dist: "./dist",
temp: "./.tmp",
app: "./app",
styles: "/styles",
scripts: "/scripts",
images: "/images",
styles: "./styles",
scripts: "./scripts",
images: "./images",
typings: "./typings",
nodeModules: "./node_modules",
jspmPackages: "./jspm_packages"
Expand Down Expand Up @@ -77,8 +77,8 @@ let javascript = {
],
srcDist: folders.temp + "/core/boot.js",
dest: folders.temp,
destDist: folders.dist + folders.scripts + "/" + finalJsBundleName,
finalJsBundlePath: folders.scripts + "/" + finalJsBundleName
destDist: folders.dist + "/" + finalJsBundleName,
finalJsBundlePath: finalJsBundleName
};

let typescript = {
Expand All @@ -88,6 +88,9 @@ let typescript = {
dest: folders.temp // JavaScript code is emitted in the temp folder
};

let finalCSSBundleName = "bundle.min.css";
let finalCSSVendorBundleName = "vendor.min.css";

let styles = {
src: [
folders.app + globs.styles.css,
Expand All @@ -103,11 +106,11 @@ let styles = {
],
dest: folders.temp, // for DEV
destFiles: folders.temp + globs.styles.css, // for DEV
destDist: folders.dist + folders.styles, // for PROD
finalCssBundleFilename: "bundle.min.css",
finalCssBundlePath: folders.styles + "/bundle.min.css",
finalVendorCssBundleFilename: "vendor.min.css",
finalVendorCssBundlePath: folders.styles + "/vendor.min.css"
destDist: folders.dist, // for PROD
finalCssBundleFilename: finalCSSBundleName,
finalCssBundlePath: finalCSSBundleName,
finalVendorCssBundleFilename: finalCSSVendorBundleName,
finalVendorCssBundlePath: finalCSSVendorBundleName
};

let images = {
Expand Down

0 comments on commit b3dd8a6

Please sign in to comment.