Remove faulty integration with Autoshare for Twitter

[elvismdev]

This hook in the Syndication Links plugin creates a conflict with the ongoing Autoshare for X + Syndication Links integration currently in progress at 10up/autoshare-for-twitter#331.

Incomplete Tweet URLs, such as https://twitter.com/i/web/status/, are being generated and added because the Syndication Links plugin hooks into autoshare_for_twitter_after_status_update to handle the same functionality being developed in the Autoshare for Twitter plugin PR.

Additionally, this implementation contains a bug in the variable names – it attempts to use the undefined variable $tweet_status, leaving $data unused.

Finally, by using add_post_syndication_link( $post->ID, $url ), it does not account for saving syndication link metadata in custom post types. This contrasts with using \Syn_Meta::add_syndication_link( $type, $post_id, $uri );, which allows specifying the post type object where the metadata should be saved through the $type parameter.

[dshanske]

This is great... I will dig in in further detail and review.