Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare documentation for final deliverables #48

Merged
merged 22 commits into from
Dec 11, 2023
Merged

Conversation

sarahwalker10
Copy link

No description provided.

@chiertu
Copy link
Contributor

chiertu commented Dec 9, 2023

So far I have checked these two scripts, making sure they run and output files at the correct places, and have doc strings:

  1. CreateFullServiceDataframe.py
  2. GenerateDistMatrix.py

I decided to archive GenerateSingleSourceofTruth.py because:

  1. it does the same thing as CreateFullServiceDataframe.py
  2. CreateFullServiceDataframe.py is better connected with downstream data processing

@chiertu
Copy link
Contributor

chiertu commented Dec 11, 2023

  1. Bike aggregation points assignment has erroneous results. Fixed that with line "key = bike_no_agg_ind[int(col)]". This change will cause changes in map and csv outputs, and possibly routing results.
  2. Comments at the end of the line was causing issue in config_inputs.ini. Fixed by moving comments into their own lines.

@chiertu
Copy link
Contributor

chiertu commented Dec 11, 2023

Some final comments:

  1. Combining sections of configuration files would eliminate lots of manual input. Ex. [convert.bike] and [optimize google cvrp]
  2. There was a bug in the bike assignment that could potentially change the routing results. I think we should rerun the optimization and generate new output files

@rahimrasool rahimrasool merged commit 5ee4872 into main Dec 11, 2023
1 check passed
@rahimrasool rahimrasool deleted the FinalDocumentation branch December 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants