Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub.io page #10

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

gamebeaker
Copy link

@gamebeaker gamebeaker commented Oct 8, 2024

reference: #8
https://pages.github.com/
It worked for me: https://gamebeaker.github.io/EpubEditor/
image
image
select master and save.
It looks like that this creates a github action
image
After a merge/ push to master it needs a few seconds until github actions is finished.

@dteviot
Copy link
Owner

dteviot commented Oct 8, 2024

@gamebeaker
I'm currently at work. Will look at this tonight when I get home.

@gamebeaker
Copy link
Author

the commit 9aa9323 is the result of

@dteviot as a "hack" you can just delete the offending part in jszip.min.js and it still works. (More tests needed)
Why do i think this is a valid solution? In my opinion the browser would block the js execution with the content_security_policy if WebToEpub should try to execute it as https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_security_policy is not set to 'unsafe-eval'. I tested it with new Function("console.log('test success');"); in main.js and get this error:
image

That is why i think this part of the code is never used in WebToEpub and can be deleted.
Replace in jszip.min.js &&(e=new function(""+e)) with nothing.
image
image
save the file and try web-ext lint it should now have no warnings.

Originally posted by @gamebeaker in dteviot/WebToEpub#1514 (comment)

I had uploaded my manipulated version and not the original version.

@dteviot dteviot merged commit 1fa2527 into dteviot:master Oct 9, 2024
@dteviot
Copy link
Owner

dteviot commented Oct 9, 2024

OK, that's it set up as a web page. Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants