util.removeEmptyDivElements() removes nested <div>

dteviot · Sep 29, 2016 · 45f5eb9 · 45f5eb9
1 parent cfc4123
commit 45f5eb9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugin/js/Util.js b/plugin/js/Util.js
@@ -128,7 +128,7 @@ var util = (function () {
 
     // discard empty divs created when moving elements
     var removeEmptyDivElements = function(element) {
-        util.removeElements(util.getElements(element, "div", e => util.isStringWhiteSpace(e.innerHTML)));
+        util.removeElements(util.getElements(element, "div", e => util.isElementWhiteSpace(e)));
     }
 
     var removeTrailingWhiteSpace = function(element) {

diff --git a/unitTest/UtestUtil.js b/unitTest/UtestUtil.js
@@ -11,13 +11,14 @@ test("removeEmptyDivElements", function (assert) {
                 "<div><h1>H1</h1></div>" +
                 "<div><div></div></div>" +
                 "<div>    \n\n\n</div>" +
+                "<div><img src=\"http://dumy.com/img.jpg\"></div>" +
             "</body>" +
         "</html>",
         "text/html");
-    let content = dom.body.cloneNode(true);
+    let content = dom.body;
     util.removeEmptyDivElements(content);
 
-    assert.equal(content.innerHTML, "<div><h1>H1</h1></div><div></div>");
+    assert.equal(content.innerHTML, "<div><h1>H1</h1></div><div><img src=\"http://dumy.com/img.jpg\"></div>");
 });
 
 test("removeScriptableElements", function (assert) {