Skip to content

Commit

Permalink
Update unit test instructions.
Browse files Browse the repository at this point in the history
See: #483
  • Loading branch information
dteviot committed Mar 3, 2021
1 parent 6144725 commit d445704
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Pull Request Check List
* Do all existing unit tests pass?
* Do all existing unit tests pass? (FYI, I find it easier to get the unit tests to run under Firefox, instead of Chrome.)
* Have all warnings and errors reported by eslint been fixed?
* If you've added new behavior,
* Can a user turn it off?
Expand Down
6 changes: 5 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,11 @@ WebToEpub uses the following libraries:
## Other notes
### To run unit tests under Chrome
* Close all running copies of Chrome
* Start Chrome with command line argument --allow-file-access-from-files
* Start Chrome with command line argument --allow-file-access-from-files. That is:
* Open a command propmt
* Browse to the directory holding Chrome
* Type in command "chrome.exe --allow-file-access-from-files" without the quotes. Press "Enter".
* If you don't do this, some tests will fail with error messages containing the text **_Failed to execute 'send' on 'XMLHttpRequest': Failed to load_**.
* Load unitTest/Tests.html
* If you get **_Failed to read the 'localStorage' property from 'Window': Access is denied for this document_** errors
* Type **_chrome://settings/content_** into Chrome's search bar
Expand Down

0 comments on commit d445704

Please sign in to comment.