Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create convertTableToDiv to fix royalroad tables on tolino #1516

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

gamebeaker
Copy link
Collaborator

@gamebeaker gamebeaker commented Sep 26, 2024

reference: #1455
To use the change add this to the Stylesheet:

.WebToEpub-table {
    border-collapse: collapse;
    width: 100%;
}
.WebToEpub-row {
    display: flex;
    border: 1px solid black;
}
.WebToEpub-cell {
    flex: 1;
    padding: 5px;
    border: 1px solid black;
}

@dteviot as this is really obscure i would appreciate other ideas to enable this option.
Maybe a new Checkbox "tolino compatibility"?.
Why not always convert tables to div?
It looks like only tolino has the problem and not other reader. As the table looks better than the div version other user shouldn't be impacted from the tolino fix.

Tested with:
https://www.royalroad.com/fiction/22546/inexorable-chaos-complete/chapter/324087/chapter-four-abnormal-summoning
There is a table in a table and the table is to long for tolino.

@gamebeaker gamebeaker merged commit 06530d8 into dteviot:ExperimentalTabMode Sep 26, 2024
1 check passed
@gamebeaker
Copy link
Collaborator Author

@dteviot

@gamebeaker I'm going to say, this isn't something for WebToEpub to do. Instead, should provide a script in EpubEditor.
Originally posted by @dteviot in #1455 (comment)

Can i leave it in WebToEpub as a "hidden" feature?
.WebToEpub-table needs to be in the Stylesheet or it is skipped.
Or should i revert the commit?

@dteviot
Copy link
Owner

dteviot commented Sep 26, 2024

@gamebeaker
Have to go to work. Will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants