-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MTLNovels support #1558
Added MTLNovels support #1558
Conversation
@maforn can you please remove the changes made to plugin/jszip/dist/jszip.min.js? |
Done, it updated automatically |
You should remove the existing file MtlnovelParser.js and its reference in popup.html. Either that, or edit MtlnovelParser.js and remove MtlnovelsParser.js. Either is fine with me. |
@maforn |
You reverted the change. There are two commits, one with the initial change, the second with jszip being reverted. I'm suggesting using a --force-with-lease to cleanup the commit. Or do a squash.
It's complicated. How to handle the library goes round and round.
Ah. My mistake, I changed MTLNovelParser.js, but did not commit it due to issues with site. Also, site seems to still be broken. If I browse to https://es.mtlnovel.com/hello-changan/, the chapters 1-250, 251-500 and 501-670 don't work. (Clicking on them to expand shows nothing.) And there's a comment dated two days ago complaining the site doesn't work. |
@dteviot |
Thank you again for your efforts. |
You're welcome! And thank you for your hard work. |
Closes #1545
I've added a new script and changed the way it fetches the chapters from MTLNovels, as of now they are not giving back the urls in a json anymore. Now the scripts scrapes the chapter list url and gets all the chapters from it.
I've tested it and it works (for me), as specified in contributing all the tests pass, I've also added my name to the contributors list.
Let me know if there are any further changes or tests that I need to make. By the way, thank you for your work, it's an amazing idea.