Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site mvlempyr #1600

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Add Site mvlempyr #1600

merged 1 commit into from
Dec 15, 2024

Conversation

ImLJS
Copy link
Collaborator

@ImLJS ImLJS commented Dec 15, 2024

Solves Issue #1568

One of the weirdest sites.

Notes:

  1. Each Novel has a slug which is used to get the Novel Id, Chapter Count but don't know from where slug is being created. Had to take the slug from image source. This api call sometimes fail. So, had to use again chapter count div to get it
  2. API call to get Chapter URL always give 404 for some reason. No time to check.

API Call to get ID : https://chp.mvlempyr.net/wp-json/wp/v2/tags?slug=6062 => {"id": 2021, "count": 190} and more
API Call to get Chapters : https://chp.mvlempyr.net/wp-json/wp/v2/posts?tags=2021&per_page=500&page=1 => Gives JSON error

@dteviot can you check

Code is working fine but is there any better implementations?

@ImLJS ImLJS requested review from dteviot and removed request for dteviot December 15, 2024 04:56
@ImLJS ImLJS merged commit cc27d12 into dteviot:ExperimentalTabMode Dec 15, 2024
1 check passed
@ImLJS ImLJS deleted the test branch December 15, 2024 09:13
@gamebeaker
Copy link
Collaborator

@ImLJS The "problem" is that the index Chapter names are Chapter 1/2/... and not the real name.
Example: https://www.mvlempyr.com/novel/my-house-of-horrors
image

for (let i = 1; i <= chapterCount; i++) {
let link = `https://www.mvlempyr.com/chapter/${slug}-${i}`;
chapterList.push({
sourceUrl: link,
title: `Chapter ${i}`
});
}

If you change line 21 to:
title: "[placeholder]"
WebToEpub will change the [placeholder] to what findChapterTitle() found.
You can test it manually:
image
It looks like this:
image
@ImLJS your decision if you want to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants