Update LessonFinishedDialog.tsx

dtiwarATS · Apr 17, 2024 · f1b700f · f1b700f
1 parent a21227a
commit f1b700f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/assets/src/apps/delivery/layouts/deck/LessonFinishedDialog.tsx b/assets/src/apps/delivery/layouts/deck/LessonFinishedDialog.tsx
@@ -2,6 +2,7 @@ import React, { Fragment, useCallback, useEffect, useState } from 'react';
 import { useSelector } from 'react-redux';
 import { ActionFailure, ActionResult, finalizePageAttempt } from 'data/persistence/page_lifecycle';
 import {
+  selectIsGraded,
   selectPageSlug,
   selectPreviewMode,
   selectResourceAttemptGuid,
@@ -23,6 +24,7 @@ const LessonFinishedDialog: React.FC<LessonFinishedDialogProps> = ({
   const [redirectURL, setRedirectURL] = useState('');
   const [finalizeError, setFinalizeError] = useState<string | null>(null);
   const isPreviewMode = useSelector(selectPreviewMode);
+  const graded = useSelector(selectIsGraded);
   const revisionSlug = useSelector(selectPageSlug);
   const sectionSlug = useSelector(selectSectionSlug);
   const resourceAttemptGuid = useSelector(selectResourceAttemptGuid);
@@ -37,7 +39,7 @@ const LessonFinishedDialog: React.FC<LessonFinishedDialogProps> = ({
       return;
     }
     setIsOpen(false);
-    if (isPreviewMode) {
+    if (!graded || isPreviewMode) {
       window.location.reload();
     } else {
       window.location.href = redirectURL;
@@ -46,7 +48,7 @@ const LessonFinishedDialog: React.FC<LessonFinishedDialogProps> = ({
 
   const handleFinalization = useCallback(async () => {
     setFinalizationCalled(true);
-    if (!isPreviewMode) {
+    if (!isPreviewMode && graded) {
       // only graded pages are finalized
       try {
         const finalizeResult = await finalizePageAttempt(
@@ -84,7 +86,7 @@ const LessonFinishedDialog: React.FC<LessonFinishedDialogProps> = ({
       }
     }
     setIsFinalized(true);
-  }, [sectionSlug, revisionSlug, resourceAttemptGuid, isPreviewMode]);
+  }, [sectionSlug, revisionSlug, resourceAttemptGuid, graded, isPreviewMode]);
 
   useEffect(() => {
     // TODO: maybe we should call finalization elsewhere than in this modal