Repository navigation
Conversation
Context values only need Display, so Display-only context could be attached but never recovered by is/downcast. Fixes dtolnay#270.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270.
.context()accepts a value that isDisplay + Send + Sync + 'static.is/downcast/downcast_ref/downcast_mutadditionally requiredDebug, so a Display-only context could be attached and then not recovered.Downcasting only needs
TypeId, which does not depend onDebug.Test plan
cargo test --test test_downcast test_downcast_display_only_context— failed to compile on master (E: Debug), passes after this changecargo test --test test_downcast— all 8 tests passcargo test --tests— integration tests passcargo test --lib— unit tests pass