Skip to content

add missing scrape-examples argument#23

Draft
syphar wants to merge 1 commit intodtolnay:masterfrom
syphar:missing-arg
Draft

add missing scrape-examples argument#23
syphar wants to merge 1 commit intodtolnay:masterfrom
syphar:missing-arg

Conversation

@syphar
Copy link

@syphar syphar commented Feb 8, 2025

I regularly recommend this cargo command to docs.rs users so they can test the output, so thanks for this!

After digging into a size difference in the actual docs.rs output and cargo docs-rs output I found this argument is missing.

See also rust-lang/docs.rs#1954 where it was added.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I would prefer not to enable this until after rust-lang/cargo#15155 is addressed.

@dtolnay dtolnay marked this pull request as draft February 8, 2025 17:54
@syphar
Copy link
Author

syphar commented Feb 12, 2026

Thanks for the PR. I would prefer not to enable this until after rust-lang/cargo#15155 is addressed.

After the release I remembered this is still open, is the idea still what you wrote here?

I really like the approach of the tool, but it would be cool if it would be as near to docs.rs as possible.

( I'm also asking myself it we could extract the "cargo-command-building" inside docs.rs into a subcrate that is used by this crate, or if it's even better to release this officially)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments