Closed
Conversation
before: `cargo test --features ci`
...
running 6 tests
test deserialize_identifier ... ok
test serialize_identifier ... ok
test deserialize_version ... ok
test serialize_version ... ok
test serialize_versionreq ... FAILED
test deserialize_versionreq ... ok
failures:
---- serialize_versionreq stdout ----
thread 'serialize_versionreq' panicked at 'assertion failed: `(left == right)`
left: `"\"=1.0.0\""`,
right: `"\"= 1.0.0\""`', tests/serde.rs:84:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
serialize_versionreq
test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Fixes: 5e87530 fix tests and formatting to comply with dtolnay#196
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Author
|
it might make sense to run the tests with the |
dtolnay
reviewed
May 25, 2021
Owner
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
The code change looks good, but this test got deleted recently, which is another way to fix it. 😜 Thanks anyway!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
cargo test --features ci...
running 6 tests
test deserialize_identifier ... ok
test serialize_identifier ... ok
test deserialize_version ... ok
test serialize_version ... ok
test serialize_versionreq ... FAILED
test deserialize_versionreq ... ok
failures:
---- serialize_versionreq stdout ----
thread 'serialize_versionreq' panicked at 'assertion failed:
(left == right)left:
"\"=1.0.0\"",right:
"\"= 1.0.0\""', tests/serde.rs:84:5note: run with
RUST_BACKTRACE=1environment variable to display a backtracefailures:
serialize_versionreq
test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Fixes: 5e87530 fix tests and formatting to comply with #196
Signed-off-by: Fabian Grünbichler f.gruenbichler@proxmox.com