Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Item::attrs and Item::attrs_mut getters #872

Closed
wants to merge 1 commit into from
Closed

Add Item::attrs and Item::attrs_mut getters #872

wants to merge 1 commit into from

Conversation

Robbepop
Copy link

Closes #866

dtolnay
dtolnay requested changes Jul 26, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you extend the documentation of each of these with some example code showing a brief realistic use case that could plausibly arise in real macro code?

dtolnay
dtolnay reviewed Sep 6, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as inactive, but please feel free to open a new pull request including the updated documentation.

@dtolnay dtolnay closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add attrs() and attrs_mut() getters to syn::Item
2 participants
@Robbepop @dtolnay