Update logging functionality to work with downstream applications#68
Merged
Conversation
|
Thanks for fixing this! |
wfordh
marked this pull request as ready for review
October 15, 2025 04:12
Collaborator
Author
|
I was able to do some quick tests locally and the fix worked. @dtsong are you or someone else able to review? |
dtsong
approved these changes
Oct 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging functionality was set up in a way that it did not work well with downstream applications that were also doing logging. After reviewing the documentation for logging (and warnings), it looks like using
logger = logging.getLogger(__name__)is the Pythonic way to handle this and will allow the downstream apps to log at their desired level, too.See
orderissue #66 for more discussion. I will take this PR off of draft mode once it is tested.