Skip to content

fix: prevent cross-repo references in GitHub Issues #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duanyytop merged 2 commits into from
Mar 10, 2026
Merged

fix: prevent cross-repo references in GitHub Issues #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c72ea
fix: prevent cross-repo references when creating GitHub Issues
duanyytop Mar 10, 2026
22535c0
fix: update test to match new plain-text reference format
duanyytop Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__tests__/prompts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe("formatItem", () => {
expect(result).toContain("作者: @alice");
expect(result).toContain("评论: 5");
expect(result).toContain("👍: 3");
expect(result).toContain("链接: https://github.com/org/repo/issues/1");
expect(result).toContain("链接: org/repo Issue #1");
expect(result).toContain("摘要: Some body text");
});

Expand Down
10 changes: 10 additions & 0 deletions src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,18 @@ export async function fetchSkillsData(repo: string): Promise<{ prs: GitHubItem[]
const GITHUB_ISSUE_BODY_LIMIT = 65536;
const TRUNCATION_NOTICE = "\n\n---\n> ⚠️ 内容超过 GitHub Issue 上限，完整报告见提交的 Markdown 文件。";

/**
* Break GitHub URLs in issue body to prevent cross-repository references.
* Inserts a zero-width space in "github.com" so GitHub's auto-linker
* won't create "mentioned this issue" notifications on external repos.
*/
function neutralizeGitHubRefs(text: string): string {
return text.replace(/https:\/\/github\.com\//g, "https://github\u200B.com/");
}

export async function createGitHubIssue(title: string, body: string, label: string): Promise<string> {
const digestRepo = process.env["DIGEST_REPO"] ?? "";
body = neutralizeGitHubRefs(body);
if (body.length > GITHUB_ISSUE_BODY_LIMIT) {
body = body.slice(0, GITHUB_ISSUE_BODY_LIMIT - TRUNCATION_NOTICE.length) + TRUNCATION_NOTICE;
}
Expand Down
6 changes: 5 additions & 1 deletion src/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,14 @@ export function formatItem(item: GitHubItem, lang: "zh" | "en" = "zh"): string {
summary: "Summary",
}
: { author: "作者", created: "创建", updated: "更新", comments: "评论", url: "链接", summary: "摘要" };
// Extract "owner/repo" from html_url to avoid full GitHub URLs that trigger cross-references
const repoSlug = item.html_url.replace(/^https:\/\/github\.com\//, "").replace(/\/(issues|pull)\/\d+$/, "");
const itemKind = item.html_url.includes("/pull/") ? "PR" : "Issue";
const refStr = `${repoSlug} ${itemKind} #${item.number}`;
return [
`#${item.number} [${item.state.toUpperCase()}]${labelStr} ${item.title}`,
` ${t.author}: @${item.user.login} | ${t.created}: ${item.created_at.slice(0, 10)} | ${t.updated}: ${item.updated_at.slice(0, 10)} | ${t.comments}: ${item.comments} | 👍: ${item.reactions?.["+1"] ?? 0}`,
` ${t.url}: ${item.html_url}`,
` ${t.url}: ${refStr}`,
` ${t.summary}: ${body}${ellipsis}`,
].join("\n");
}
Expand Down